[ https://issues.apache.org/jira/browse/HIVE-14016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15925020#comment-15925020 ]
Hive QA commented on HIVE-14016: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12858748/HIVE-14016.07.patch {color:green}SUCCESS:{color} +1 due to 22 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 5 failed/errored test(s), 10358 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_count] (batchId=13) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_empty_where] (batchId=22) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_grouping_sets] (batchId=77) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vectorization_limit] (batchId=34) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_if_expr] (batchId=141) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/4131/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/4131/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-4131/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 5 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12858748 - PreCommit-HIVE-Build > Vectorization: Add support for Grouping Sets > -------------------------------------------- > > Key: HIVE-14016 > URL: https://issues.apache.org/jira/browse/HIVE-14016 > Project: Hive > Issue Type: Improvement > Components: Vectorization > Reporter: Gopal V > Assignee: Matt McCline > Attachments: HIVE-14016.01.patch, HIVE-14016.02.patch, > HIVE-14016.03.patch, HIVE-14016.04.patch, HIVE-14016.05.patch, > HIVE-14016.06.patch, HIVE-14016.07.patch > > > Rollup and Cube queries are not vectorized today due to the miss of > grouping-sets inside vector group by. > The cube and rollup operators can be shimmed onto the end of the pipeline by > converting a single row writer into a multiple row writer. > The corresponding non-vec loop is as follows > {code} > if (groupingSetsPresent) { > Object[] newKeysArray = newKeys.getKeyArray(); > Object[] cloneNewKeysArray = new Object[newKeysArray.length]; > for (int keyPos = 0; keyPos < groupingSetsPosition; keyPos++) { > cloneNewKeysArray[keyPos] = newKeysArray[keyPos]; > } > for (int groupingSetPos = 0; groupingSetPos < groupingSets.size(); > groupingSetPos++) { > for (int keyPos = 0; keyPos < groupingSetsPosition; keyPos++) { > newKeysArray[keyPos] = null; > } > FastBitSet bitset = groupingSetsBitSet[groupingSetPos]; > // Some keys need to be left to null corresponding to that grouping > set. > for (int keyPos = bitset.nextSetBit(0); keyPos >= 0; > keyPos = bitset.nextSetBit(keyPos+1)) { > newKeysArray[keyPos] = cloneNewKeysArray[keyPos]; > } > newKeysArray[groupingSetsPosition] = > newKeysGroupingSets[groupingSetPos]; > processKey(row, rowInspector); > } > } > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346)