[ 
https://issues.apache.org/jira/browse/HIVE-16206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15925527#comment-15925527
 ] 

Sunitha Beeram commented on HIVE-16206:
---------------------------------------

I have an initial patch available - this is my first contribution to apache 
projects, so please do let me know if anything is amiss/non-conformant.

I have updated the current test case to work with the new conf that the patch 
introduces - once I get some feedback on the change, I plan to add tests for 
the existing conf to ensure backward compatibility is covered as well.

> Make Codahale metrics reporters pluggable
> -----------------------------------------
>
>                 Key: HIVE-16206
>                 URL: https://issues.apache.org/jira/browse/HIVE-16206
>             Project: Hive
>          Issue Type: Improvement
>          Components: Metastore
>            Reporter: Sunitha Beeram
>            Assignee: Sunitha Beeram
>         Attachments: HIVE-16206.patch
>
>
> Hive metrics code currently allows pluggable metrics handlers - ie, handlers 
> that take care of providing interfaces for metrics collection as well as a 
> reporting; one of the 'handlers' is CodahaleMetrics. Codahale can work with 
> different reporters - currently supported ones are Console, JMX, JSON file 
> and hadoop2 sink. However, adding a new reporter involves changing that 
> class. We would like to make this conf driven just the way MetricsFactory 
> handles configurable Metrics classes.
> Scope of work:
> - Provide a new configuration option, HIVE_CODAHALE_REPORTER_CLASSES that 
> enumerates classes (like HIVE_METRICS_CLASS and unlike HIVE_METRICS_REPORTER).
> - Move JsonFileReporter into its own class.
> - Update CodahaleMetrics.java to read new config option and if the new option 
> is not present, look for the old option and instantiate accordingly) - ie, 
> make the code backward compatible.
> - Update and add new tests.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to