[ 
https://issues.apache.org/jira/browse/HIVE-16416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15968706#comment-15968706
 ] 

Peter Vary commented on HIVE-16416:
-----------------------------------

+1 LGTM (non-binding)

> Service: move constants out from HiveAuthFactory
> ------------------------------------------------
>
>                 Key: HIVE-16416
>                 URL: https://issues.apache.org/jira/browse/HIVE-16416
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Server Infrastructure
>            Reporter: Zoltan Haindrich
>            Assignee: Zoltan Haindrich
>         Attachments: HIVE-16416.1.patch
>
>
> It took me a while to notice that there are only some constants which are 
> keep pulling in this class :)
> it contains a tricky dependency to the whole ql module; but in client mode 
> that part is totally unused - moving the constants out from it, enables the 
> client to operate without the factory.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to