[
https://issues.apache.org/jira/browse/HIVE-16427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15971802#comment-15971802
]
Ashutosh Chauhan commented on HIVE-16427:
-----------------------------------------
Patch looks good. Couple of stylistic improvements:
* Can you rename canSkipData() to isNullOpPresentInAllBranches() ?
* Also, add a comment for method something like following : {{ We need to make
sure that Null Operator (LIM or FIL) is present in all branches of multi-insert
query before applying the optimization. This method does full tree traversal
starting from TS and will return true only if it finds target Null operator on
each branch }} Add/edit comment as you find appropriate.
> Fix multi-insert query and write qtests
> ---------------------------------------
>
> Key: HIVE-16427
> URL: https://issues.apache.org/jira/browse/HIVE-16427
> Project: Hive
> Issue Type: Bug
> Components: Logical Optimizer
> Reporter: Thomas Poepping
> Assignee: Yongzhi Chen
> Attachments: HIVE-16427.1.patch, HIVE-16427.2.patch
>
>
> On HIVE-16415, it was found that the bug reported to be fixed in HIVE-14519
> was not actually fixed.
> This task is to find the problem, fix it, and add qtests to verify no future
> regression.
> Specifically, the following query does not produce correct answers:
> {code}
> From (select * from src) a
> insert overwrite directory '/tmp/emp/dir1/'
> select key, value
> insert overwrite directory '/tmp/emp/dir2/'
> select 'header'
> limit 0
> insert overwrite directory '/tmp/emp/dir3/'
> select key, value
> where key = 100;
> {code}
> This gives incorrect result in master. All dirs end up with 0 rows instead of
> just dir2.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
