[ 
https://issues.apache.org/jira/browse/HIVE-16363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976868#comment-15976868
 ] 

Sahil Takiar commented on HIVE-16363:
-------------------------------------

[~spena] addressed your comments, could you take another look?

Test failures are flaky:

HIVE-15776 - TestMiniLlapLocalCliDriver.testCliDriver[vector_if_expr]

> QueryLifeTimeHooks should catch parse exceptions
> ------------------------------------------------
>
>                 Key: HIVE-16363
>                 URL: https://issues.apache.org/jira/browse/HIVE-16363
>             Project: Hive
>          Issue Type: Bug
>          Components: Hooks
>            Reporter: Sahil Takiar
>            Assignee: Sahil Takiar
>         Attachments: HIVE-16363.1.patch, HIVE-16363.2.patch, 
> HIVE-16363.3.patch, HIVE-16363.4.patch, HIVE-16363.5.patch, HIVE-16363.6.patch
>
>
> The {{QueryLifeTimeHook}} objects do not catch exceptions during query 
> parsing, only query compilation. New methods should be added to hook into pre 
> and post parsing of the query.
> This should be done in a backwards incompatible way so that current 
> implementations of this hook do not break.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to