[
https://issues.apache.org/jira/browse/HIVE-14881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15981650#comment-15981650
]
Eugene Koifman commented on HIVE-14881:
---------------------------------------
As we discussed, I think adding a new compaction type here is going to cause
confusion longer term.
Also, if you make Worker delete the Directory. getAbortedDirectories(), then
the Cleaner doesn't have to change at all and probably has better scalability.
getAbortedDirectories() shoudl have have a JavaDoc that it's a list of deltas
that have nothing but aborted txns.
I'd change
{noformat}
if (MetaStoreUtils.isInsertOnlyTable(tblproperties) &&
1013 txnList.isTxnAborted(delta.minTransaction)) { // for MM
table, minTxnId & maxTxnId is same
1014 aborted.add(child);
1015 }
{noformat}
to check that all txns between min/max for current delta and if so, add the
delta to the list - this way the code is not specific to MM tables and the
collection being build may be useful somewhere else.
> integrate MM tables into ACID: merge cleaner into ACID threads
> ---------------------------------------------------------------
>
> Key: HIVE-14881
> URL: https://issues.apache.org/jira/browse/HIVE-14881
> Project: Hive
> Issue Type: Sub-task
> Components: Transactions
> Reporter: Sergey Shelukhin
> Assignee: Wei Zheng
> Attachments: HIVE-14881.1.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
