[ 
https://issues.apache.org/jira/browse/HIVE-16539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16001093#comment-16001093
 ] 

Juan Rodríguez Hortalá commented on HIVE-16539:
-----------------------------------------------

Hi Sergio, thanks for taking a look to the code review. The problem with this 
patch is that I have added a ORC file, and patches created with `git diff 
--no-prefix` following 
https://cwiki.apache.org/confluence/display/Hive/HowToContribute#HowToContribute-CreatingaPatch
 don't work ok with binary files. I sent an email to d...@hive.apache.org about 
this, and [~owen.omalley] suggested to use ` git format-patch --stdout`, which 
works ok when you apply the patch with `git apply` (HIVE-16539.3.patch), but 
from the message above it looks like Hive QA is not able to process that 
because it is trying to use `path -p0` or `path -p1` or `path -p2`. Can you 
please provide instructions to build a patch that includes a binary file? 

Thanks!

> Add PTF tests for blobstores
> ----------------------------
>
>                 Key: HIVE-16539
>                 URL: https://issues.apache.org/jira/browse/HIVE-16539
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 2.1.1
>            Reporter: Juan Rodríguez Hortalá
>            Assignee: Juan Rodríguez Hortalá
>             Fix For: 2.2.0
>
>         Attachments: HIVE-16539.2.patch, HIVE-16539.3.patch, HIVE-16539.patch
>
>
> This patch covers 6 tests that check the integration of several Partitioned 
> Table Functions with blobstores



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to