[
https://issues.apache.org/jira/browse/HIVE-15051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16007885#comment-16007885
]
Peter Vary edited comment on HIVE-15051 at 5/12/17 9:52 AM:
------------------------------------------------------------
Thanks for looking to this [~thejas]!
Uploaded the current status of the patch (Interim.patch). To run it, we need
HIVE-15725 (needed), and HIVE-15726 (optional). Both patches are available, and
waiting for review/commit.
After applying and committing the patch to the local branch you can run the
following script from a clean (HEAD+2) hive source root:
{code}
./[petervary:~/dev/upstream/hive] $ export
FINDBUGS_HOME=~/dev/upstream/findbugs-3.0.1/
./[petervary:~/dev/upstream/hive] $ ./dev-support/test-patch.sh
~/Downloads/HIVE-16345.2.patch
{code}
You have to set FINDBUGS_HOME to run findbugs tests.
This will generate something like the attached beeline.out, and ql.out output
to the terminal.
Current status:
- Needs the previously mentioned HIVE-15725, HIVE-15726 jiras before this can
be committed.
- When the patch contains new Vectorization txt files, then the sources are not
generated by Yetus. I might just have to change which mvn parameters should be
used. Have to find out how these files are generated in the first place :)
- YETUS-488 is a nice to have.
Planned:
- We should integrate it to Jira, and the we can have a report like this:
https://issues.apache.org/jira/browse/YARN-6363?focusedCommentId=15937570&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15937570
To be honest, I have found that this patch has limited support from the
community, and the TestBeeLineDriver patches sparked much more interest. Those
are currently consume most of my time, but if someone with a committership
could review and commit, then I would be happy to pick up this again! :)
Thanks,
Peter
~edit: Added that FINDBUGS_HOME should be set~
was (Author: pvary):
Thanks for looking to this [~thejas]!
Uploaded the current status of the patch (Interim.patch). To run it, we need
HIVE-15725 (needed), and HIVE-15726 (optional). Both patches are available, and
waiting for review/commit.
After applying and committing the patch to the local branch you can run the
following script from a clean (HEAD+2) hive source root:
{code}
./[petervary:~/dev/upstream/hive] $ ./dev-support/test-patch.sh
~/Downloads/HIVE-16345.2.patch
{code}
This will generate something like the attached beeline.out, and ql.out output
to the terminal.
Current status:
- Needs the previously mentioned HIVE-15725, HIVE-15726 jiras before this can
be committed.
- When the patch contains new Vectorization txt files, then the sources are not
generated by Yetus. I might just have to change which mvn parameters should be
used. Have to find out how these files are generated in the first place :)
- YETUS-488 is a nice to have.
Planned:
- We should integrate it to Jira, and the we can have a report like this:
https://issues.apache.org/jira/browse/YARN-6363?focusedCommentId=15937570&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15937570
To be honest, I have found that this patch has limited support from the
community, and the TestBeeLineDriver patches sparked much more interest. Those
are currently consume most of my time, but if someone with a committership
could review and commit, then I would be happy to pick up this again! :)
Thanks,
Peter
> Test framework integration with findbugs, rat checks etc.
> ---------------------------------------------------------
>
> Key: HIVE-15051
> URL: https://issues.apache.org/jira/browse/HIVE-15051
> Project: Hive
> Issue Type: Sub-task
> Components: Testing Infrastructure
> Reporter: Peter Vary
> Assignee: Peter Vary
> Attachments: beeline.out, Interim.patch, ql.out
>
>
> Find a way to integrate code analysis tools like findbugs, rat checks to
> PreCommit tests, thus removing the burden from reviewers to check the code
> style and other checks which could be done by code.
> Might worth to take a look on Yetus, but keep in mind the Hive has a specific
> parallel test framework.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
