[
https://issues.apache.org/jira/browse/HIVE-16711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16016918#comment-16016918
]
Vihang Karajgaonkar commented on HIVE-16711:
--------------------------------------------
[~ngangam] There was no specific issue or usecase which prompted this change.
[~spena] pointed out that {{PROPERTY_ID}} wasn't really needed and its not
used. Earlier I thought that datanucleus needs it to identify each instance of
the row returned from the tableto have a identity type in order to manage the
table. But seems like if we change the identity type to application we can do
away with the id column and let the application (HMS) decide how to identify
each instance of row by changing {{PROPERTY_KEY}} to primary key instead. This
doesn't change the usecase or behavior of the thrift API just gets rid of the
extra column.
Out of the 5 test failures following 4 have been failing since last many builds.
{noformat}
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_if_expr]
(batchId=144)
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainanalyze_3]
(batchId=97)
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainuser_3]
(batchId=97)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query24]
(batchId=231)
{noformat}
The 5th one {{columnstats_part_coltype}} is a known flaky test reported in
HIVE-15169
> Remove property_id column from metastore_db_properties table
> ------------------------------------------------------------
>
> Key: HIVE-16711
> URL: https://issues.apache.org/jira/browse/HIVE-16711
> Project: Hive
> Issue Type: Improvement
> Reporter: Vihang Karajgaonkar
> Assignee: Vihang Karajgaonkar
> Priority: Minor
> Attachments: HIVE-16711.01.patch, HIVE-16711.02.patch
>
>
> The property id column of the table {{METASTORE_DB_PROPERTIES}} is not really
> needed. We could instead convert column {{PROPERTY_KEY}} to primary key and
> change the identity-type to "application" in package.jdo file.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
