[
https://issues.apache.org/jira/browse/HIVE-16727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16026037#comment-16026037
]
Sankar Hariappan commented on HIVE-16727:
-----------------------------------------
[~anishek],
Please find my responses here and let me know if any concerns.
{quote}
TestReplicationScenarios : The test case seems to test both partitioned and
unpartitioned cases in the same test case, It would be easier to spot errors if
they were split if into two tests cases one for partition and another for
unpartitioned tables, will also additionally make it more readable. Might be
possible to abstract most of the commands using the WarehouseInstance
{quote}
- As the InsertEvent handling is common for both partitioned and unpartitioned
table, I intended to keep one test case for this scenario. Also, REPL dump will
process these insert events one by one which helps to spot the errors easily if
one fails.Using WarehouseInstance, I shall able to abstract the dump commands
but it is not too many in this test case and this change can be more, so, think
of doing it for future patches. :)
{quote}
InsertEvent: get_table_core could be used since this is for internal hive
classes.
{quote}
- In the base code for Repl dump was using get_table_req after setting this
req.setCapabilities(HiveMetaStoreClient.TEST_VERSION); Not sure, why is it
there. However, even get_table_req internally invokes get_table_core. So,
shouldn't be a problem I guess.
{quote}
There are unused Imports in most of the classes above.
{quote}
- Yes, agreed. Will share a patch removing all these unused imports from files
modified.
> REPL DUMP for insert event should't fail if the table is already dropped.
> -------------------------------------------------------------------------
>
> Key: HIVE-16727
> URL: https://issues.apache.org/jira/browse/HIVE-16727
> Project: Hive
> Issue Type: Sub-task
> Components: Hive, repl
> Affects Versions: 2.1.0
> Reporter: Sankar Hariappan
> Assignee: Sankar Hariappan
> Labels: DR, replication
> Attachments: HIVE-16727.01.patch
>
>
> Currently, insert event doesn't log the table object as part of event
> notification message. During dump, the table object is obtained from
> metastore which can be null if the table is already dropped and hence REPL
> DUMP fails.
> Steps:
> 1. Bootstrap dump/load with a table.
> 2. Insert into the table.
> 3. Drop the table.
> 4. REPL DUMP (incremental).
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
