[ https://issues.apache.org/jira/browse/HIVE-16355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16078679#comment-16078679 ]
Vaibhav Gumashta commented on HIVE-16355: ----------------------------------------- Thanks for looking into this [~kgyrtkirk]. I agree, for now using the ServiceLoader approach might be an overkill since there is only one implementation. Added some minor comments on rb. > Service: embedded mode should only be available if service is loaded onto the > classpath > --------------------------------------------------------------------------------------- > > Key: HIVE-16355 > URL: https://issues.apache.org/jira/browse/HIVE-16355 > Project: Hive > Issue Type: Sub-task > Components: Metastore, Server Infrastructure > Reporter: Zoltan Haindrich > Assignee: Zoltan Haindrich > Attachments: HIVE-16355.1.patch, HIVE-16355.2.patch, > HIVE-16355.2.patch, HIVE-16355.3.patch, HIVE-16355.4.patch > > > I would like to relax the hard reference to > {{EmbeddedThriftBinaryCLIService}} to be only used in case {{service}} module > is loaded onto the classpath. -- This message was sent by Atlassian JIRA (v6.4.14#64029)