[ 
https://issues.apache.org/jira/browse/HIVE-17005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087751#comment-16087751
 ] 

Sushanth Sowmyan commented on HIVE-17005:
-----------------------------------------

Thanks for the additional catch, added them into .3.patch and committed. 
Autoformatting did not add them, and I had to go through that manually, but it 
looks like I missed a couple. At some point, requiring a checkstyle as part of 
compile, and fixing code across hive might be a worthy endeavour(although very 
very costly). It's actually a thing I like about go - what the programmer 
writes is irrelevant, as part of the "make" process, it always formats all code 
to "one true style". :)



> Ensure REPL DUMP and REPL LOAD are authorized properly
> ------------------------------------------------------
>
>                 Key: HIVE-17005
>                 URL: https://issues.apache.org/jira/browse/HIVE-17005
>             Project: Hive
>          Issue Type: Sub-task
>          Components: repl
>            Reporter: Sushanth Sowmyan
>            Assignee: Sushanth Sowmyan
>             Fix For: 3.0.0
>
>         Attachments: HIVE-17005.2.patch, HIVE-17005.3.patch, HIVE-17005.patch
>
>
> Currently, we piggyback REPL DUMP and REPL LOAD on EXPORT and IMPORT auth 
> privileges. However, work is on to not populate all the relevant objects in 
> inputObjs and outputObjs, which then requires that REPL DUMP and REPL LOAD be 
> authorized at a higher level, and simply require ADMIN_PRIV to run,



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to