[ 
https://issues.apache.org/jira/browse/HIVE-17019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16088180#comment-16088180
 ] 

Siddharth Seth commented on HIVE-17019:
---------------------------------------

bq. The llap status is fetched using LlapStatusServiceDriver which is part of 
hive-llap-server.
OK. llap-status should really be under it's own module. Anyway, that can be 
changed later. Another alternate is to have llap-status hosted as a webservice. 
That can happen in a follow up. Would be really good to skip the llap-server 
dependency, which in turn pulls in a lot of others.

bq. Creating a shared executor, does it make sense to use Guava's direct 
executor, which will schedule task in current thread.
Sure. It could just be done inline otherwise? The main question is how the 
total number of downloads are restricted. Restricting the number of handlers on 
the web interface does not help, since that serves out a lot more than download 
debug artifacts.

bq. For streaming directly, it would not be possible because of multithreading. 
If its single threaded then I can use a ZipOutputStream and add entry one at a 
time.
Think this is ok as long as files are cleaned up. May want to cap file sizes as 
well, since logs can get really large.

bq. I was planning to remove this and integrate with hive cli, --service 
<download_logs>. This does not work without lot of classpath fixes, or I'll 
have to create a script to add hive jars.
Sounds good.

bq. Will check a few libs, apache commons OptionBuilder uses a static instance 
in its builder. Should be ok, for a cli based invoke once app, but will look at 
something better on lines of python argparse.
Sounds good. Maybe in a follow up jira to get this in faster?

bq. Sure, will do. Global or per download or both?
Global, defined by the server.

bq. Stop if no new sources could download or all sources are exhausted.
Sounds good. I misread the code, sorry.

bq. Jetty will handle the exception, returning 500 to the user. Not sure if 
exception trace is part of it. Will try and see.
Think this is ok as long as the error has enough information to let the user 
know what happened.





> Add support to download debugging information as an archive.
> ------------------------------------------------------------
>
>                 Key: HIVE-17019
>                 URL: https://issues.apache.org/jira/browse/HIVE-17019
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Harish Jaiprakash
>            Assignee: Harish Jaiprakash
>         Attachments: HIVE-17019.01.patch
>
>
> Given a queryId or dagId, get all information related to it: like, tez am, 
> task logs, hive ats data, tez ats data, slider am status, etc. Package it 
> into and archive.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to