[
https://issues.apache.org/jira/browse/HIVE-17117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097880#comment-16097880
]
PRASHANT GOLASH commented on HIVE-17117:
----------------------------------------
[~csun] and [~mohitsabharwal]
Did some analysis on failing tests:
Out of 12 failing tests, 4 passed on my local machine with fix:
org.apache.hadoop.hive.cli.TestBeeLineDriver.testCliDriver[materialized_view_create_rewrite]
org.apache.hadoop.hive.cli.TestBeeLineDriver.testCliDriver[insert_overwrite_local_directory_1]
org.apache.hadoop.hive.cli.TestBeeLineDriver.testCliDriver[create_merge_compressed]
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[orc_merge8]
8 still failed. the errors don't seem to be related to my change, and i found
same error on other builds for these tests.
org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[spark_vectorized_dynamic_partition_pruning]
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query23]
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query14]
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[subquery_scalar]
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[llap_smb]
org.apache.hive.hcatalog.api.TestHCatClient.testTableSchemaPropagation
org.apache.hive.hcatalog.api.TestHCatClient.testPartitionSpecRegistrationWithCustomSchema
org.apache.hive.hcatalog.api.TestHCatClient.testPartitionRegistrationWithCustomSchema
> Metalisteners are not notified when threadlocal metaconf is cleanup
> --------------------------------------------------------------------
>
> Key: HIVE-17117
> URL: https://issues.apache.org/jira/browse/HIVE-17117
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Environment: Tested on master branch (Applicable for downlevel
> versions as well)
> Reporter: PRASHANT GOLASH
> Assignee: PRASHANT GOLASH
> Priority: Minor
> Attachments: HIVE-17117.1.patch, HIVE-17117.patch
>
>
> Meta listeners are not notified of meta-conf cleanup. This could potentially
> leave stale values on listeners objects. For e.g.
> Request1
> a. HS2 -> HMS : HMSHandler#setMetaConf
> MetaListeners are notified of the ConfigChangeEvent.
> b. HS2 -> HMS : HMSHandler#shutdown / HiveMetaStore#deleteContext (if
> shutdown is not invoked)
> MetaConf is cleaned up in HiveMetaStore#cleanupRawStore, but meta
> listeners are not notified
> Request 2
> 3. HS2->HMS : AlterPartition
> MetaListeners are notified of AlterPartitionEvent. If any listener has
> taken dependency on the meta conf value, it will still be having stale value
> from Request1 and would potentially be having issues.
> The correct behavior should be to notify meta listeners on cleanup as well.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
