[ https://issues.apache.org/jira/browse/HIVE-15225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118237#comment-16118237 ]
Hive QA commented on HIVE-15225: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12839260/HIVE-15225.1.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 11 failed/errored test(s), 10993 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestBeeLineDriver.testCliDriver[insert_overwrite_local_directory_1] (batchId=240) org.apache.hadoop.hive.cli.TestBeeLineDriver.testCliDriver[materialized_view_create_rewrite] (batchId=240) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[llap_uncompressed] (batchId=56) org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[spark_dynamic_partition_pruning_mapjoin_only] (batchId=170) org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[spark_vectorized_dynamic_partition_pruning] (batchId=169) org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainanalyze_2] (batchId=100) org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainuser_3] (batchId=99) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query14] (batchId=235) org.apache.hive.hcatalog.api.TestHCatClient.testPartitionRegistrationWithCustomSchema (batchId=180) org.apache.hive.hcatalog.api.TestHCatClient.testPartitionSpecRegistrationWithCustomSchema (batchId=180) org.apache.hive.hcatalog.api.TestHCatClient.testTableSchemaPropagation (batchId=180) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/6296/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/6296/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-6296/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 11 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12839260 - PreCommit-HIVE-Build > QueryPlan.getJSONValue should code against empty string values > -------------------------------------------------------------- > > Key: HIVE-15225 > URL: https://issues.apache.org/jira/browse/HIVE-15225 > Project: Hive > Issue Type: Bug > Reporter: Yibing Shi > Assignee: Yibing Shi > Attachments: HIVE-15225.1.patch > > > The current {{QueryPlan.getJSONValue}} implementation is as below: > {code} > public String getJSONValue(Object value) { > String v = "null"; > if (value != null) { > v = value.toString(); > if (v.charAt(0) != '[' && v.charAt(0) != '{') { > v = "\"" + v + "\""; > } > } > return v; > } > {code} > When {{value.toString()}} returns an empty string, a > StringIndexOutOfRangeException would be thrown out when "v.charAt(0)" is > evaluated. -- This message was sent by Atlassian JIRA (v6.4.14#64029)