[
https://issues.apache.org/jira/browse/HIVE-17268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118342#comment-16118342
]
Peter Vary commented on HIVE-17268:
-----------------------------------
I think it is acceptable, that the {{hive.log.explain.output}} could not be set
per session basis, so I agree with your solution.
However this patch fixes changes made by HIVE-16982. I would prefer to revert
to the original code since the expected output is the same in case of {{null}}
value. By this, I mean we should revert the changes in the getExplainPlan
method to {{returnStringOrUnknown(explainPlan)}}, and add the config check
directly to the jamon file as you did in this patch.
If it would be a green field code, I would prefer to do the check on the jamon
side, but several other places we use the returnStringOrUnknown to handle
null-s, and in case of codebase this big I prefer uniformity above all :)
Thanks for the report and the patch!
Peter
> WebUI / QueryPlan: query plan is sometimes null when explain output conf is on
> ------------------------------------------------------------------------------
>
> Key: HIVE-17268
> URL: https://issues.apache.org/jira/browse/HIVE-17268
> Project: Hive
> Issue Type: Bug
> Reporter: Karen Coppage
> Assignee: Karen Coppage
> Priority: Minor
> Attachments: HIVE-17268.patch
>
>
> The Hive WebUI's Query Plan tab displays "SET hive.log.explain.output TO true
> TO VIEW PLAN" even when hive.log.explain.output is set to true, when the
> query cannot be compiled, because the plan is null in this case.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
