[ 
https://issues.apache.org/jira/browse/HIVE-17235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118605#comment-16118605
 ] 

Owen O'Malley commented on HIVE-17235:
--------------------------------------

Ok, this patch makes sense because it doesn't break the API. You should add a 
test case for some special values (eg. +/- 999,999,999,999,999,999; +/- 
0.999,999,999,999,999,999; and +/- 123,456,789,012,345,678)

I'll file my patch as a new jira.

> Add ORC Decimal64 Serialization/Deserialization (Part 1)
> --------------------------------------------------------
>
>                 Key: HIVE-17235
>                 URL: https://issues.apache.org/jira/browse/HIVE-17235
>             Project: Hive
>          Issue Type: Bug
>          Components: Hive
>            Reporter: Matt McCline
>            Assignee: Matt McCline
>            Priority: Critical
>         Attachments: HIVE-17235.03.patch, HIVE-17235.04.patch, 
> HIVE-17235.05.patch, HIVE-17235.06.patch, HIVE-17235.07.patch, 
> HIVE-17235.patch
>
>
> The storage-api changes for ORC-209.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to