[
https://issues.apache.org/jira/browse/HIVE-17313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125563#comment-16125563
]
ASF GitHub Bot commented on HIVE-17313:
---------------------------------------
GitHub user dosoft opened a pull request:
https://github.com/apache/hive/pull/230
HIVE-17313: Fixed 'case fall-through'
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dosoft/hive HIVE-17313
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/hive/pull/230.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #230
----
commit 2f322ea6d6a9b5754c0c9b698395d8b3e94563f7
Author: Oleg Danilov <o...@olegd.com>
Date: 2017-08-14T11:28:47Z
HIVE-17313: Fixed 'case fall-through'
----
> Potentially possible 'case fall through' in the ObjectInspectorConverters
> -------------------------------------------------------------------------
>
> Key: HIVE-17313
> URL: https://issues.apache.org/jira/browse/HIVE-17313
> Project: Hive
> Issue Type: Bug
> Reporter: Oleg Danilov
> Assignee: Oleg Danilov
> Priority: Trivial
>
> Lines 103-110:
> {code:java}
> case STRING:
> if (outputOI instanceof WritableStringObjectInspector) {
> return new PrimitiveObjectInspectorConverter.TextConverter(
> inputOI);
> } else if (outputOI instanceof JavaStringObjectInspector) {
> return new PrimitiveObjectInspectorConverter.StringConverter(
> inputOI);
> }
> case CHAR:
> {code}
> De-facto it should work correctly since outputOI is either an instance of
> WritableStringObjectInspector or JavaStringObjectInspector, but it would be
> better to rewrite this case to avoid possible fall through.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
