[ 
https://issues.apache.org/jira/browse/HIVE-16811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16142945#comment-16142945
 ] 

Hive QA commented on HIVE-16811:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12883960/HIVE-16811.9.patch

{color:red}ERROR:{color} -1 due to build exiting with an error

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/6561/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/6561/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-6561/

Messages:
{noformat}
**** This message was trimmed, see log for full details ****
patching file ql/src/test/results/clientpositive/llap/vector_coalesce_2.q.out
patching file ql/src/test/results/clientpositive/llap/vector_complex_all.q.out
patching file ql/src/test/results/clientpositive/llap/vector_complex_join.q.out
patching file ql/src/test/results/clientpositive/llap/vector_count.q.out
patching file 
ql/src/test/results/clientpositive/llap/vector_count_distinct.q.out
patching file ql/src/test/results/clientpositive/llap/vector_data_types.q.out
patching file ql/src/test/results/clientpositive/llap/vector_date_1.q.out
patching file ql/src/test/results/clientpositive/llap/vector_decimal_1.q.out
patching file ql/src/test/results/clientpositive/llap/vector_decimal_10_0.q.out
patching file 
ql/src/test/results/clientpositive/llap/vector_decimal_aggregate.q.out
patching file 
ql/src/test/results/clientpositive/llap/vector_decimal_expressions.q.out
patching file 
ql/src/test/results/clientpositive/llap/vector_decimal_mapjoin.q.out
patching file 
ql/src/test/results/clientpositive/llap/vector_decimal_math_funcs.q.out
patching file 
ql/src/test/results/clientpositive/llap/vector_decimal_precision.q.out
patching file ql/src/test/results/clientpositive/llap/vector_decimal_round.q.out
patching file ql/src/test/results/clientpositive/llap/vector_decimal_udf.q.out
patching file ql/src/test/results/clientpositive/llap/vector_decimal_udf2.q.out
patching file ql/src/test/results/clientpositive/llap/vector_distinct_2.q.out
patching file ql/src/test/results/clientpositive/llap/vector_groupby4.q.out
patching file ql/src/test/results/clientpositive/llap/vector_groupby6.q.out
patching file ql/src/test/results/clientpositive/llap/vector_groupby_3.q.out
patching file ql/src/test/results/clientpositive/llap/vector_groupby_cube1.q.out
patching file 
ql/src/test/results/clientpositive/llap/vector_groupby_grouping_id1.q.out
patching file 
ql/src/test/results/clientpositive/llap/vector_groupby_grouping_id2.q.out
patching file 
ql/src/test/results/clientpositive/llap/vector_groupby_grouping_id3.q.out
patching file 
ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets1.q.out
patching file 
ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets2.q.out
patching file 
ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets3.q.out
patching file 
ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets4.q.out
patching file 
ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets5.q.out
patching file 
ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets6.q.out
patching file 
ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets_grouping.q.out
patching file 
ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets_limit.q.out
patching file 
ql/src/test/results/clientpositive/llap/vector_groupby_reduce.q.out
patching file 
ql/src/test/results/clientpositive/llap/vector_groupby_rollup1.q.out
patching file ql/src/test/results/clientpositive/llap/vector_grouping_sets.q.out
patching file 
ql/src/test/results/clientpositive/llap/vector_include_no_sel.q.out
patching file ql/src/test/results/clientpositive/llap/vector_inner_join.q.out
patching file ql/src/test/results/clientpositive/llap/vector_interval_1.q.out
patching file ql/src/test/results/clientpositive/llap/vector_interval_2.q.out
patching file 
ql/src/test/results/clientpositive/llap/vector_interval_arithmetic.q.out
patching file 
ql/src/test/results/clientpositive/llap/vector_interval_mapjoin.q.out
patching file ql/src/test/results/clientpositive/llap/vector_join30.q.out
patching file 
ql/src/test/results/clientpositive/llap/vector_left_outer_join2.q.out
patching file 
ql/src/test/results/clientpositive/llap/vector_leftsemi_mapjoin.q.out
patching file 
ql/src/test/results/clientpositive/llap/vector_mr_diff_schema_alias.q.out
patching file ql/src/test/results/clientpositive/llap/vector_nullsafe_join.q.out
patching file 
ql/src/test/results/clientpositive/llap/vector_number_compare_projection.q.out
patching file ql/src/test/results/clientpositive/llap/vector_orderby_5.q.out
patching file ql/src/test/results/clientpositive/llap/vector_outer_join0.q.out
patching file 
ql/src/test/results/clientpositive/llap/vector_partition_diff_num_cols.q.out
patching file 
ql/src/test/results/clientpositive/llap/vector_partitioned_date_time.q.out
patching file 
ql/src/test/results/clientpositive/llap/vector_ptf_part_simple.q.out
patching file ql/src/test/results/clientpositive/llap/vector_reduce1.q.out
patching file ql/src/test/results/clientpositive/llap/vector_reduce2.q.out
patching file ql/src/test/results/clientpositive/llap/vector_reduce3.q.out
patching file 
ql/src/test/results/clientpositive/llap/vector_reduce_groupby_decimal.q.out
patching file ql/src/test/results/clientpositive/llap/vector_string_concat.q.out
patching file ql/src/test/results/clientpositive/llap/vector_struct_in.q.out
patching file ql/src/test/results/clientpositive/llap/vector_udf1.q.out
patching file 
ql/src/test/results/clientpositive/llap/vector_udf_character_length.q.out
patching file 
ql/src/test/results/clientpositive/llap/vector_udf_octet_length.q.out
patching file ql/src/test/results/clientpositive/llap/vector_varchar_4.q.out
patching file 
ql/src/test/results/clientpositive/llap/vector_varchar_mapjoin1.q.out
patching file 
ql/src/test/results/clientpositive/llap/vector_varchar_simple.q.out
patching file 
ql/src/test/results/clientpositive/llap/vector_when_case_null.q.out
patching file 
ql/src/test/results/clientpositive/llap/vector_windowing_navfn.q.out
patching file 
ql/src/test/results/clientpositive/llap/vectorization_decimal_date.q.out
patching file 
ql/src/test/results/clientpositive/llap/vectorization_part_project.q.out
patching file 
ql/src/test/results/clientpositive/llap/vectorization_short_regress.q.out
patching file 
ql/src/test/results/clientpositive/llap/vectorized_bucketmapjoin1.q.out
patching file ql/src/test/results/clientpositive/llap/vectorized_context.q.out
patching file 
ql/src/test/results/clientpositive/llap/vectorized_date_funcs.q.out
patching file 
ql/src/test/results/clientpositive/llap/vectorized_distinct_gby.q.out
patching file 
ql/src/test/results/clientpositive/llap/vectorized_dynamic_partition_pruning.q.out
patching file 
ql/src/test/results/clientpositive/llap/vectorized_dynamic_semijoin_reduction.q.out
patching file ql/src/test/results/clientpositive/llap/vectorized_join46.q.out
patching file ql/src/test/results/clientpositive/llap/vectorized_parquet.q.out
patching file 
ql/src/test/results/clientpositive/llap/vectorized_parquet_types.q.out
patching file ql/src/test/results/clientpositive/llap/vectorized_ptf.q.out
patching file ql/src/test/results/clientpositive/llap/vectorized_timestamp.q.out
patching file 
ql/src/test/results/clientpositive/llap/vectorized_timestamp_funcs.q.out
patching file ql/src/test/results/clientpositive/merge_join_1.q.out
patching file ql/src/test/results/clientpositive/mergejoin.q.out
patching file ql/src/test/results/clientpositive/mergejoins_mixed.q.out
patching file ql/src/test/results/clientpositive/perf/query23.q.out
patching file ql/src/test/results/clientpositive/ppd_join5.q.out
patching file ql/src/test/results/clientpositive/ppd_outer_join5.q.out
patching file ql/src/test/results/clientpositive/smb_mapjoin_47.q.out
patching file 
ql/src/test/results/clientpositive/spark/auto_join_reordering_values.q.out
patching file ql/src/test/results/clientpositive/spark/auto_join_stats.q.out
patching file ql/src/test/results/clientpositive/spark/auto_join_stats2.q.out
patching file ql/src/test/results/clientpositive/spark/auto_smb_mapjoin_14.q.out
patching file 
ql/src/test/results/clientpositive/spark/auto_sortmerge_join_12.q.out
patching file 
ql/src/test/results/clientpositive/spark/auto_sortmerge_join_6.q.out
patching file 
ql/src/test/results/clientpositive/spark/auto_sortmerge_join_9.q.out
patching file 
ql/src/test/results/clientpositive/spark/bucket_map_join_tez1.q.out
patching file 
ql/src/test/results/clientpositive/spark/bucket_map_join_tez2.q.out
patching file ql/src/test/results/clientpositive/spark/column_access_stats.q.out
patching file ql/src/test/results/clientpositive/spark/join19.q.out
patching file 
ql/src/test/results/clientpositive/spark/join_cond_pushdown_unqual1.q.out
patching file 
ql/src/test/results/clientpositive/spark/join_cond_pushdown_unqual2.q.out
patching file 
ql/src/test/results/clientpositive/spark/join_cond_pushdown_unqual3.q.out
patching file 
ql/src/test/results/clientpositive/spark/join_cond_pushdown_unqual4.q.out
patching file ql/src/test/results/clientpositive/spark/join_hive_626.q.out
patching file ql/src/test/results/clientpositive/spark/join_star.q.out
patching file ql/src/test/results/clientpositive/spark/mergejoins_mixed.q.out
patching file ql/src/test/results/clientpositive/spark/ppd_join5.q.out
patching file ql/src/test/results/clientpositive/spark/ppd_outer_join5.q.out
patching file 
ql/src/test/results/clientpositive/spark/spark_dynamic_partition_pruning.q.out
patching file 
ql/src/test/results/clientpositive/spark/spark_dynamic_partition_pruning_mapjoin_only.q.out
patching file ql/src/test/results/clientpositive/spark/spark_explainuser_1.q.out
patching file ql/src/test/results/clientpositive/spark/spark_use_op_stats.q.out
patching file ql/src/test/results/clientpositive/spark/stats_only_null.q.out
patching file 
ql/src/test/results/clientpositive/spark/table_access_keys_stats.q.out
patching file ql/src/test/results/clientpositive/stats_only_null.q.out
patching file ql/src/test/results/clientpositive/stats_partial_size.q.out
patching file ql/src/test/results/clientpositive/stats_ppr_all.q.out
patching file ql/src/test/results/clientpositive/tez/explainanalyze_2.q.out
patching file ql/src/test/results/clientpositive/tez/explainanalyze_3.q.out
patching file ql/src/test/results/clientpositive/tez/explainanalyze_5.q.out
patching file ql/src/test/results/clientpositive/tez/explainuser_3.q.out
patching file 
ql/src/test/results/clientpositive/tez/hybridgrace_hashjoin_1.q.out
patching file ql/src/test/results/clientpositive/tez/multi_count_distinct.q.out
patching file ql/src/test/results/clientpositive/tez/tez-tag.q.out
patching file 
ql/src/test/results/clientpositive/tez/vector_join_part_col_char.q.out
patching file 
ql/src/test/results/clientpositive/tez/vector_non_string_partition.q.out
patching file 
ql/src/test/results/clientpositive/vector_mr_diff_schema_alias.q.out
patching file ql/src/test/results/clientpositive/vector_outer_join6.q.out
patching file ql/src/test/results/clientpositive/vectorized_context.q.out
+ [[ maven == \m\a\v\e\n ]]
+ rm -rf /data/hiveptest/working/maven/org/apache/hive
+ mvn -B clean install -DskipTests -T 4 -q 
-Dmaven.repo.local=/data/hiveptest/working/maven
DataNucleus Enhancer (version 4.1.17) for API "JDO"
DataNucleus Enhancer : Classpath
>>  /usr/share/maven/boot/plexus-classworlds-2.x.jar
ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MDatabase
ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MFieldSchema
ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MType
ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MTable
ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MConstraint
ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MSerDeInfo
ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MOrder
ENHANCED (Persistable) : 
org.apache.hadoop.hive.metastore.model.MColumnDescriptor
ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MStringList
ENHANCED (Persistable) : 
org.apache.hadoop.hive.metastore.model.MStorageDescriptor
ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MPartition
ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MIndex
ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MRole
ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MRoleMap
ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MGlobalPrivilege
ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MDBPrivilege
ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MTablePrivilege
ENHANCED (Persistable) : 
org.apache.hadoop.hive.metastore.model.MPartitionPrivilege
ENHANCED (Persistable) : 
org.apache.hadoop.hive.metastore.model.MTableColumnPrivilege
ENHANCED (Persistable) : 
org.apache.hadoop.hive.metastore.model.MPartitionColumnPrivilege
ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MPartitionEvent
ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MMasterKey
ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MDelegationToken
ENHANCED (Persistable) : 
org.apache.hadoop.hive.metastore.model.MTableColumnStatistics
ENHANCED (Persistable) : 
org.apache.hadoop.hive.metastore.model.MPartitionColumnStatistics
ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MVersionTable
ENHANCED (Persistable) : 
org.apache.hadoop.hive.metastore.model.MMetastoreDBProperties
ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MResourceUri
ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MFunction
ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MNotificationLog
ENHANCED (Persistable) : 
org.apache.hadoop.hive.metastore.model.MNotificationNextId
DataNucleus Enhancer completed with success for 31 classes. Timings : input=391 
ms, enhance=314 ms, total=705 ms. Consult the log for full details
ANTLR Parser Generator  Version 3.5.2
Output file 
/data/hiveptest/working/apache-github-source-source/metastore/target/generated-sources/antlr3/org/apache/hadoop/hive/metastore/parser/FilterParser.java
 does not exist: must build 
/data/hiveptest/working/apache-github-source-source/metastore/src/java/org/apache/hadoop/hive/metastore/parser/Filter.g
org/apache/hadoop/hive/metastore/parser/Filter.g
ANTLR Parser Generator  Version 3.5.2
Output file 
/data/hiveptest/working/apache-github-source-source/ql/target/generated-sources/antlr3/org/apache/hadoop/hive/ql/parse/HiveLexer.java
 does not exist: must build 
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g
org/apache/hadoop/hive/ql/parse/HiveLexer.g
Output file 
/data/hiveptest/working/apache-github-source-source/ql/target/generated-sources/antlr3/org/apache/hadoop/hive/ql/parse/HiveParser.java
 does not exist: must build 
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g
org/apache/hadoop/hive/ql/parse/HiveParser.g
Output file 
/data/hiveptest/working/apache-github-source-source/ql/target/generated-sources/antlr3/org/apache/hadoop/hive/ql/parse/HintParser.java
 does not exist: must build 
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/hadoop/hive/ql/parse/HintParser.g
org/apache/hadoop/hive/ql/parse/HintParser.g
Generating vector expression code
Generating vector expression test code
[ERROR] COMPILATION ERROR : 
[ERROR] 
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java:[1005,47]
 cannot find symbol
  symbol:   variable TIMESTAMPTZ_TYPE_NAME
  location: class org.apache.hadoop.hive.serde.serdeConstants
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile (default-compile) 
on project hive-exec: Compilation failure
[ERROR] 
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java:[1005,47]
 cannot find symbol
[ERROR] symbol:   variable TIMESTAMPTZ_TYPE_NAME
[ERROR] location: class org.apache.hadoop.hive.serde.serdeConstants
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please 
read the following articles:
[ERROR] [Help 1] 
http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <goals> -rf :hive-exec
+ exit 1
'
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12883960 - PreCommit-HIVE-Build

> Estimate statistics in absence of stats
> ---------------------------------------
>
>                 Key: HIVE-16811
>                 URL: https://issues.apache.org/jira/browse/HIVE-16811
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Vineet Garg
>            Assignee: Vineet Garg
>         Attachments: HIVE-16811.1.patch, HIVE-16811.2.patch, 
> HIVE-16811.3.patch, HIVE-16811.4.patch, HIVE-16811.5.patch, 
> HIVE-16811.6.patch, HIVE-16811.7.patch, HIVE-16811.8.patch, HIVE-16811.9.patch
>
>
> Currently Join ordering completely bails out in absence of statistics and 
> this could lead to bad joins such as cross joins.
> e.g. following select query will produce cross join.
> {code:sql}
> create table supplier (S_SUPPKEY INT, S_NAME STRING, S_ADDRESS STRING, 
> S_NATIONKEY INT, 
> S_PHONE STRING, S_ACCTBAL DOUBLE, S_COMMENT STRING)
> CREATE TABLE lineitem (L_ORDERKEY      INT,
>                                 L_PARTKEY       INT,
>                                 L_SUPPKEY       INT,
>                                 L_LINENUMBER    INT,
>                                 L_QUANTITY      DOUBLE,
>                                 L_EXTENDEDPRICE DOUBLE,
>                                 L_DISCOUNT      DOUBLE,
>                                 L_TAX           DOUBLE,
>                                 L_RETURNFLAG    STRING,
>                                 L_LINESTATUS    STRING,
>                                 l_shipdate      STRING,
>                                 L_COMMITDATE    STRING,
>                                 L_RECEIPTDATE   STRING,
>                                 L_SHIPINSTRUCT  STRING,
>                                 L_SHIPMODE      STRING,
>                                 L_COMMENT       STRING) partitioned by (dl 
> int)
> ROW FORMAT DELIMITED
> FIELDS TERMINATED BY '|';
> CREATE TABLE part(
>     p_partkey INT,
>     p_name STRING,
>     p_mfgr STRING,
>     p_brand STRING,
>     p_type STRING,
>     p_size INT,
>     p_container STRING,
>     p_retailprice DOUBLE,
>     p_comment STRING
> );
> explain select count(1) from part,supplier,lineitem where p_partkey = 
> l_partkey and s_suppkey = l_suppkey;
> {code}
> Estimating stats will prevent join ordering algorithm to bail out and come up 
> with join at least better than cross join 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to