[ 
https://issues.apache.org/jira/browse/HIVE-17508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16183096#comment-16183096
 ] 

Sergey Shelukhin commented on HIVE-17508:
-----------------------------------------

Having multiple rules on the same variable can happen due to operator error (or 
intentional design when the operator is too lazy to delete old rules)... it 
should at least error out in this case. Using findFirst in some places seems to 
pick one random rule.
I think the current factory pretends to be a parser :) If we want a parser we 
should use antlr. Otherwise for now it should be more primitive, maybe 
literally just split the string on '>' then. But it's a minor comment.

> Implement pool rules and triggers based on counters
> ---------------------------------------------------
>
>                 Key: HIVE-17508
>                 URL: https://issues.apache.org/jira/browse/HIVE-17508
>             Project: Hive
>          Issue Type: Sub-task
>    Affects Versions: 3.0.0
>            Reporter: Prasanth Jayachandran
>            Assignee: Prasanth Jayachandran
>         Attachments: HIVE-17508.1.patch, HIVE-17508.2.patch, 
> HIVE-17508.3.patch, HIVE-17508.3.patch, HIVE-17508.WIP.2.patch, 
> HIVE-17508.WIP.patch
>
>
> Workload management can defined Rules that are bound to a resource plan. Each 
> rule can have a trigger expression and an action associated with it. Trigger 
> expressions are evaluated at runtime after configurable check interval, based 
> on which actions like killing a query, moving a query to different pool etc. 
> will get invoked. Simple rule could be something like
> {code}
> CREATE RULE slow_query IN resource_plan_name
> WHEN execution_time_ms > 10000
> MOVE TO slow_queue
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to