[ https://issues.apache.org/jira/browse/HIVE-17139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16186989#comment-16186989 ]
Hive QA commented on HIVE-17139: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12889834/HIVE-17139.18.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 10 failed/errored test(s), 11177 tests executed *Failed tests:* {noformat} TestSSL - did not produce a TEST-*.xml file (likely timed out) (batchId=226) org.apache.hadoop.hive.cli.TestAccumuloCliDriver.testCliDriver[accumulo_predicate_pushdown] (batchId=232) org.apache.hadoop.hive.cli.TestAccumuloCliDriver.testCliDriver[accumulo_single_sourced_multi_insert] (batchId=232) org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[unionDistinct_1] (batchId=144) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[optimize_nullscan] (batchId=162) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[union_fast_stats] (batchId=157) org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[spark_explainuser_1] (batchId=171) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query14] (batchId=240) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query23] (batchId=240) org.apache.hadoop.hive.cli.control.TestDanglingQOuts.checkDanglingQOut (batchId=203) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/7064/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/7064/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-7064/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 10 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12889834 - PreCommit-HIVE-Build > Conditional expressions optimization: skip the expression evaluation if the > condition is not satisfied for vectorization engine. > -------------------------------------------------------------------------------------------------------------------------------- > > Key: HIVE-17139 > URL: https://issues.apache.org/jira/browse/HIVE-17139 > Project: Hive > Issue Type: Improvement > Reporter: Ke Jia > Assignee: Ke Jia > Attachments: HIVE-17139.10.patch, HIVE-17139.11.patch, > HIVE-17139.12.patch, HIVE-17139.13.patch, HIVE-17139.13.patch, > HIVE-17139.14.patch, HIVE-17139.15.patch, HIVE-17139.16.patch, > HIVE-17139.17.patch, HIVE-17139.18.patch, HIVE-17139.18.patch, > HIVE-17139.1.patch, HIVE-17139.2.patch, HIVE-17139.3.patch, > HIVE-17139.4.patch, HIVE-17139.5.patch, HIVE-17139.6.patch, > HIVE-17139.7.patch, HIVE-17139.8.patch, HIVE-17139.9.patch > > > The case when and if statement execution for Hive vectorization is not > optimal, which all the conditional and else expressions are evaluated for > current implementation. The optimized approach is to update the selected > array of batch parameter after the conditional expression is executed. Then > the else expression will only do the selected rows instead of all. -- This message was sent by Atlassian JIRA (v6.4.14#64029)