[ 
https://issues.apache.org/jira/browse/HIVE-17733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16198365#comment-16198365
 ] 

Zoltan Haindrich commented on HIVE-17733:
-----------------------------------------

[~alangates] I guess metastoreutils is ok for now...I think we should try to 
remove as much stuff from that class as possible later (last time I played with 
metastore client separation; the metastoreutils ended up as a public api part) 
- I think the most important is to avoid the appearance of HMSHandler in 
classes which will be later part of the public api will be benefical.

I think probably later we should file some followups to remove undesired 
options from the metastore ( which will cause trouble later like this one)
https://github.com/apache/hive/pull/258/files?w=1#diff-61434f2dd7a5fe334625e19ef2405ed3L592
I feel that statistics gathering is kinda out of scope for the metastore.

I've seen a possibly notable thing:
https://github.com/apache/hive/pull/258/files?w=1#diff-3d07754b1de8dc5a50a3395b7d6f9045L513
the old one permitted to pass all kind of settings to the persistence layer; 
the new version adds an extra "filtering" on top of it; I think instead of 
re-declaring all kind of jdo/jpa/xxx args in metastore's conf; we should 
provide some generic way to pass props to the jpa implementation; I would like 
to propose that we might pass a subtree of settings to the jpa implementation ( 
without the sub-tree prefix ) - although I'm not sure how often these 
properties are being used by the enduser....
beyond this, everything looks good.


> Move RawStore to standalone metastore
> -------------------------------------
>
>                 Key: HIVE-17733
>                 URL: https://issues.apache.org/jira/browse/HIVE-17733
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Metastore
>            Reporter: Alan Gates
>            Assignee: Alan Gates
>              Labels: pull-request-available
>         Attachments: HIVE-17733.2.patch, HIVE-17733.patch
>
>
> This includes moving implementations of RawStore (like ObjectStore), 
> MetastoreDirectSql, and stats related classes like ColumnStatsAggregator and 
> the NDV classes.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to