[ https://issues.apache.org/jira/browse/HIVE-17743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16199810#comment-16199810 ]
Hive QA commented on HIVE-17743: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12891332/HIVE-17743.2.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 3 failed/errored test(s), 11204 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[optimize_nullscan] (batchId=162) org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainanalyze_2] (batchId=101) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query14] (batchId=239) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/7222/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/7222/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-7222/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 3 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12891332 - PreCommit-HIVE-Build > Add InterfaceAudience and InterfaceStability annotations for Thrift generated > APIs > ---------------------------------------------------------------------------------- > > Key: HIVE-17743 > URL: https://issues.apache.org/jira/browse/HIVE-17743 > Project: Hive > Issue Type: Sub-task > Components: Thrift API > Reporter: Sahil Takiar > Assignee: Sahil Takiar > Attachments: HIVE-17743.1.patch, HIVE-17743.2.patch > > > The Thrift generated files don't have {{InterfaceAudience}} or > {{InterfaceStability}} annotations on them, mainly because all the files are > auto-generated. > We should add some code that auto-tags all the Java Thrift generated files > with these annotations. This way even when they are re-generated, they still > contain the annotations. > We should be able to do this using the > {{com.google.code.maven-replacer-plugin}} similar to what we do in > {{standalone-metastore/pom.xml}}. -- This message was sent by Atlassian JIRA (v6.4.14#64029)