[
https://issues.apache.org/jira/browse/HIVE-17771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16204118#comment-16204118
]
Sergey Shelukhin edited comment on HIVE-17771 at 10/13/17 8:15 PM:
-------------------------------------------------------------------
The patch so far makes sense to me.
Nit: " throw new SemanticException("Invalid syntax for CREATE RESOURCE PLAN
statement is c/ped for show plan.
Also I see it passes null-s/false-s for permission stuff in HiveOperation.java.
It seems to be in line with existing stuff where priviledges only apply to
table/partition/view/etc. operations, but it was surprising to me.
[~thejas] I see that admin commands like grant role, etc. don't have any
privileges associated with them in HiveOperation.java. How does one control
access to that stuff?
[~harishjp] do you want to expand this patch with more commands or to commit
this and have another JIRA?
Also TestHiveOperationType failed, probably an enum value needs to be added
somewhere.
was (Author: sershe):
The patch so far makes sense to me.
Nit: " throw new SemanticException("Invalid syntax for CREATE RESOURCE PLAN
statement is c/ped for show plan.
Also I see it passes null-s/false-s for permission stuff in HiveOperation.java.
It seems to be in line with existing stuff where priviledges only apply to
table/partition/view/etc. operations, but it was surprising to me.
[~thejas] I see that admin commands like grant role, etc. don't have any
privileges associated with them in HiveOperation.java. How does one control
access to that stuff?
[~harishjp] do you want to expand this patch with more commands or to commit
this and have another JIRA?
Also TestHiveOperation failed, probably an enum value needs to be added
somewhere.
> Implement create and show resource plan.
> ----------------------------------------
>
> Key: HIVE-17771
> URL: https://issues.apache.org/jira/browse/HIVE-17771
> Project: Hive
> Issue Type: Sub-task
> Reporter: Harish Jaiprakash
> Assignee: Harish Jaiprakash
> Attachments: HIVE-17771.01.patch
>
>
> Please see parent jira about llap workload management.
> This jira is to implement create and show resource plan commands in hive to
> configure resource plans for llap workload.
> The following are the proposed commands implemented as part of the jira:
> CREATE RESOURCE PLAN plan_name WITH QUERY_PARALLELISM parallelism;
> SHOW RESOURCE PLAN;
> It will be followed up with more jiras to add pools, triggers and copy
> resource plans. And also with drop commands for each of them.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
