[ 
https://issues.apache.org/jira/browse/HIVE-17765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208437#comment-16208437
 ] 

Thejas M Nair commented on HIVE-17765:
--------------------------------------

 * In TestJdbcDriver2.java, can you change the single line for loop to 
following to make it more readable ?
{code}
..
boolean found = false;
for(String keyword : keywords) {
 if( "limit".equals(keyword) ){
    found = true;
 }
}
...
{code}


 * service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java . 
Can you make that an umodifiable set ? (Guava Collections.unmodifiableSet ).
 * You can also initialize above in constructor using "new HashSet<> 
(Arrays.asList("ABSOLUTE", ... ) "


 

> expose Hive keywords 
> ---------------------
>
>                 Key: HIVE-17765
>                 URL: https://issues.apache.org/jira/browse/HIVE-17765
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Sergey Shelukhin
>            Assignee: Thejas M Nair
>         Attachments: HIVE-17765.01.patch, HIVE-17765.02.patch, 
> HIVE-17765.nogen.patch, HIVE-17765.patch
>
>
> This could be useful e.g. for BI tools (via ODBC/JDBC drivers) to decide on 
> SQL capabilities of Hive



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to