[ 
https://issues.apache.org/jira/browse/HIVE-17304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16213456#comment-16213456
 ] 

Prasanth Jayachandran commented on HIVE-17304:
----------------------------------------------

No. This needs further testing. I need to do some in-depth analysis to see 
which one is more accurate to the actual value based on heapdumps. So it's not 
ready for commit yet.

> ThreadMXBean based memory allocation monitory for hash table loader
> -------------------------------------------------------------------
>
>                 Key: HIVE-17304
>                 URL: https://issues.apache.org/jira/browse/HIVE-17304
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Prasanth Jayachandran
>            Assignee: Prasanth Jayachandran
>         Attachments: HIVE-17304.1.patch, HIVE-17304.2.patch
>
>
> Hash table memory monitoring is based on java data model which can be 
> unreliable because of various reasons (wrong object size estimation, adding 
> new variables to any class without accounting its size for memory monitoring, 
> etc.). We can use allocation size per thread that is provided by ThreadMXBean 
> and fallback to DataModel in case if JDK doesn't support thread based 
> allocations. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to