[ https://issues.apache.org/jira/browse/HIVE-11812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16222515#comment-16222515 ]
Hive QA commented on HIVE-11812: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12830654/HIVE-11812.1.patch {color:red}ERROR:{color} -1 due to build exiting with an error Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/7505/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/7505/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-7505/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Tests exited with: NonZeroExitCodeException Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit status 1 and output '+ date '+%Y-%m-%d %T.%3N' 2017-10-27 15:03:40.083 + [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]] + export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + export PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m ' + ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m ' + export 'MAVEN_OPTS=-Xmx1g ' + MAVEN_OPTS='-Xmx1g ' + cd /data/hiveptest/working/ + tee /data/hiveptest/logs/PreCommit-HIVE-Build-7505/source-prep.txt + [[ false == \t\r\u\e ]] + mkdir -p maven ivy + [[ git = \s\v\n ]] + [[ git = \g\i\t ]] + [[ -z master ]] + [[ -d apache-github-source-source ]] + [[ ! -d apache-github-source-source/.git ]] + [[ ! -d apache-github-source-source ]] + date '+%Y-%m-%d %T.%3N' 2017-10-27 15:03:40.085 + cd apache-github-source-source + git fetch origin + git reset --hard HEAD HEAD is now at 88bd58e HIVE-17764 : alter view fails when hive.metastore.disallow.incompatible.col.type.changes set to true (Janaki Lahorani, reviewed by Andrew Sherman and Vihang Karajgaonkar) (addendum) + git clean -f -d Removing standalone-metastore/src/gen/org/ + git checkout master Already on 'master' Your branch is up-to-date with 'origin/master'. + git reset --hard origin/master HEAD is now at 88bd58e HIVE-17764 : alter view fails when hive.metastore.disallow.incompatible.col.type.changes set to true (Janaki Lahorani, reviewed by Andrew Sherman and Vihang Karajgaonkar) (addendum) + git merge --ff-only origin/master Already up-to-date. + date '+%Y-%m-%d %T.%3N' 2017-10-27 15:03:44.874 + patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh + patchFilePath=/data/hiveptest/working/scratch/build.patch + [[ -f /data/hiveptest/working/scratch/build.patch ]] + chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh + /data/hiveptest/working/scratch/smart-apply-patch.sh /data/hiveptest/working/scratch/build.patch error: a/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateDiff.java: No such file or directory error: a/ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFDateDiff.java: No such file or directory The patch does not appear to apply with p0, p1, or p2 + exit 1 ' {noformat} This message is automatically generated. ATTACHMENT ID: 12830654 - PreCommit-HIVE-Build > datediff sometimes returns incorrect results when called with dates > ------------------------------------------------------------------- > > Key: HIVE-11812 > URL: https://issues.apache.org/jira/browse/HIVE-11812 > Project: Hive > Issue Type: Bug > Components: UDF > Affects Versions: 2.0.0 > Reporter: Nicholas Brenwald > Assignee: Chetna Chaudhari > Priority: Minor > Labels: timestamp > Attachments: HIVE-11812.1.patch > > > DATEDIFF returns an incorrect result when one of the arguments is a date > type. > The Hive Language Manual provides the following signature for datediff: > {code} > int datediff(string enddate, string startdate) > {code} > I think datediff should either throw an error (if date types are not > supported), or return the correct result. > To reproduce, create a table: > {code} > create table t (c1 string, c2 date); > {code} > Assuming you have a table x containing some data, populate table t with 1 row: > {code} > insert into t select '2015-09-15', '2015-09-15' from x limit 1; > {code} > Then run the following 12 test queries: > {code} > select datediff(c1, '2015-09-14') from t; > select datediff(c1, '2015-09-15') from t; > select datediff(c1, '2015-09-16') from t; > select datediff('2015-09-14', c1) from t; > select datediff('2015-09-15', c1) from t; > select datediff('2015-09-16', c1) from t; > select datediff(c2, '2015-09-14') from t; > select datediff(c2, '2015-09-15') from t; > select datediff(c2, '2015-09-16') from t; > select datediff('2015-09-14', c2) from t; > select datediff('2015-09-15', c2) from t; > select datediff('2015-09-16', c2) from t; > {code} > The below table summarises the result. All results for column c1 (which is a > string) are correct, but when using c2 (which is a date), two of the results > are incorrect. > || Test || Expected Result || Actual Result || Passed / Failed || > |datediff(c1, '2015-09-14')| 1 | 1| Passed | > |datediff(c1, '2015-09-15')| 0 | 0| Passed | > |datediff(c1, '2015-09-16') | -1 | -1| Passed | > |datediff('2015-09-14', c1) | -1 | -1| Passed | > |datediff('2015-09-15', c1)| 0 | 0| Passed | > |datediff('2015-09-16', c1)| 1 | 1| Passed | > |datediff(c2, '2015-09-14')| 1 | 0| {color:red}Failed{color} | > |datediff(c2, '2015-09-15')| 0 | 0| Passed | > |datediff(c2, '2015-09-16') | -1 | -1| Passed | > |datediff('2015-09-14', c2) | -1 | 0 | {color:red}Failed{color} | > |datediff('2015-09-15', c2)| 0 | 0| Passed | > |datediff('2015-09-16', c2)| 1 | 1| Passed | -- This message was sent by Atlassian JIRA (v6.4.14#64029)