[ https://issues.apache.org/jira/browse/HIVE-17979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16239061#comment-16239061 ]
Hive QA commented on HIVE-17979: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12895984/HIVE-17979.1.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 19 failed/errored test(s), 11354 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[insert_values_orig_table_use_metadata] (batchId=62) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[llap_acid_fast] (batchId=157) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[sysdb] (batchId=156) org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[spark_dynamic_partition_pruning_2] (batchId=175) org.apache.hadoop.hive.cli.TestNegativeMinimrCliDriver.testCliDriver[ct_noperm_loc] (batchId=94) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[subquery_multi] (batchId=111) org.apache.hadoop.hive.cli.control.TestDanglingQOuts.checkDanglingQOut (batchId=206) org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testAmPoolInteractions (batchId=281) org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testApplyPlanQpChanges (batchId=281) org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testApplyPlanUserMapping (batchId=281) org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testAsyncSessionInitFailures (batchId=281) org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testClusterFractions (batchId=281) org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testDestroyAndReturn (batchId=281) org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testQueueing (batchId=281) org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testReopen (batchId=281) org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testReuse (batchId=281) org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testReuseWithDifferentPool (batchId=281) org.apache.hadoop.hive.ql.exec.tez.TestWorkloadManager.testReuseWithQueueing (batchId=281) org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testConstraints (batchId=223) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/7637/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/7637/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-7637/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 19 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12895984 - PreCommit-HIVE-Build > Tez: Improve ReduceRecordSource passDownKey copying > --------------------------------------------------- > > Key: HIVE-17979 > URL: https://issues.apache.org/jira/browse/HIVE-17979 > Project: Hive > Issue Type: Improvement > Affects Versions: 3.0.0 > Reporter: Gopal V > Assignee: Gopal V > Priority: Major > Attachments: HIVE-17979.1.patch > > > Tez does not use a single Key stream for both sides of the join, so each > input gets its own ReduceRecordSource > {code} > sources[tag] = new ReduceRecordSource(); > {code} > And this means for each input stream, there's a deserialized key (because the > tag is not part of the Key byte stream), this means for a 2-table join there > are 2 ReduceRecordSource objects. > This means that the passDownKey is only an optimization when the Key, > List<Value> has more than 1 value in it. Otherwise the copy is entirely > wasted CPU cycles, because it deserializes the entire row to extract the key > and discards the row. -- This message was sent by Atlassian JIRA (v6.4.14#64029)