[ https://issues.apache.org/jira/browse/HIVE-17981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16282270#comment-16282270 ]
Alan Gates commented on HIVE-17981: ----------------------------------- [~pvary] reviewers are always welcome, no need to ask. Also note that I have refactored the builders a little in the patch for HIVE-17990 which is currently on the standalone-metastore branch in commit bd212257f2c8f5472894e22501b17a56fd86318c > Create a set of builders for Thrift classes > ------------------------------------------- > > Key: HIVE-17981 > URL: https://issues.apache.org/jira/browse/HIVE-17981 > Project: Hive > Issue Type: Sub-task > Components: Standalone Metastore > Reporter: Alan Gates > Assignee: Alan Gates > Labels: pull-request-available > Attachments: HIVE-17981.patch > > > Instantiating some of the Thrift classes is painful. Consider building a > {{Table}} object, which requires a {{StorageDescriptor}}, which requires a > {{SerDeInfo}} and a list of {{FieldInfo}}. All that is really necessary for > a Table in the most simple case is a name, a database, and some columns. But > currently creating even a simple Table requires 20+ lines of code. This is > particularly painful in tests. > I propose to add a set of builders. These will come with reasonable defaults > to minimize the boilerplate code. They will also include simple methods for > common operations (like adding columns, or a parameter) without requiring the > user to create all the sub-objects (like {{StorageDescriptor}}). -- This message was sent by Atlassian JIRA (v6.4.14#64029)