[ https://issues.apache.org/jira/browse/HIVE-18240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16284682#comment-16284682 ]
Hive QA commented on HIVE-18240: -------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Findbugs executables are not available. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 23s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m 21s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 21s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 38s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 58s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 21s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 18s{color} | {color:red} service in the patch failed. {color} | | {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 18s{color} | {color:red} service in the patch failed. {color} | | {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 18s{color} | {color:red} service in the patch failed. {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 13s{color} | {color:red} service: The patch generated 35 new + 122 unchanged - 0 fixed = 157 total (was 122) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 10s{color} | {color:red} jdbc: The patch generated 12 new + 67 unchanged - 0 fixed = 79 total (was 67) {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch has 17 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 57s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 12s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 15m 43s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus/dev-support/hive-personality.sh | | git revision | master / 5bbd864 | | Default Java | 1.8.0_111 | | mvninstall | http://104.198.109.242/logs//PreCommit-HIVE-Build-8159/yetus/patch-mvninstall-service.txt | | compile | http://104.198.109.242/logs//PreCommit-HIVE-Build-8159/yetus/patch-compile-service.txt | | javac | http://104.198.109.242/logs//PreCommit-HIVE-Build-8159/yetus/patch-compile-service.txt | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-8159/yetus/diff-checkstyle-service.txt | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-8159/yetus/diff-checkstyle-jdbc.txt | | whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-8159/yetus/whitespace-eol.txt | | modules | C: service-rpc service jdbc itests/hive-unit U: . | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-8159/yetus.txt | | Powered by | Apache Yetus http://yetus.apache.org | This message was automatically generated. > support getClientInfo/setClientInfo in JDBC > ------------------------------------------- > > Key: HIVE-18240 > URL: https://issues.apache.org/jira/browse/HIVE-18240 > Project: Hive > Issue Type: Bug > Reporter: Sergey Shelukhin > Assignee: Sergey Shelukhin > Attachments: HIVE-18240.01.patch, HIVE-18240.patch > > > These are JDBC APIs that allow the user of the driver to provide client info > to the server; the list of the fields supported by the driver is returned as > a result set by getClientInfoProperties API. > I've looked at IBM, Oracle, MS etc. docs and it seems like ApplicationName is > a common one; there's also ClientHostname, etc. that we don't need because > HS2 derives them already. > The client will then set these properties via setClientInfo if desired. > Whether it is desired by any BI tools of significance I've no idea. > The properties are sent to the server on connect (which is what Microsoft > seems to do, but in Hive model it's impossible because HiveConnection > connects in ctor), or on the next query (I don't recall where I've seen > this), or immediately (which is what I do in this patch). > The getClientInfo API on the driver side seems completely pointless, so I > cache clientinfo locally for it. -- This message was sent by Atlassian JIRA (v6.4.14#64029)