[ https://issues.apache.org/jira/browse/HIVE-17896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16293084#comment-16293084 ]
Hive QA commented on HIVE-17896: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12902200/HIVE-17896.2.patch {color:red}ERROR:{color} -1 due to build exiting with an error Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/8273/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/8273/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-8273/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Tests exited with: NonZeroExitCodeException Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit status 1 and output '+ date '+%Y-%m-%d %T.%3N' 2017-12-15 19:37:01.257 + [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]] + export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + export PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m ' + ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m ' + export 'MAVEN_OPTS=-Xmx1g ' + MAVEN_OPTS='-Xmx1g ' + cd /data/hiveptest/working/ + tee /data/hiveptest/logs/PreCommit-HIVE-Build-8273/source-prep.txt + [[ false == \t\r\u\e ]] + mkdir -p maven ivy + [[ git = \s\v\n ]] + [[ git = \g\i\t ]] + [[ -z master ]] + [[ -d apache-github-source-source ]] + [[ ! -d apache-github-source-source/.git ]] + [[ ! -d apache-github-source-source ]] + date '+%Y-%m-%d %T.%3N' 2017-12-15 19:37:01.261 + cd apache-github-source-source + git fetch origin + git reset --hard HEAD HEAD is now at f52e8b4 HIVE-18258: Vectorization: Reduce-Side GROUP BY MERGEPARTIAL with duplicate columns is broken (Matt McCline, reviewed by Teddy Choi) + git clean -f -d + git checkout master Already on 'master' Your branch is up-to-date with 'origin/master'. + git reset --hard origin/master HEAD is now at f52e8b4 HIVE-18258: Vectorization: Reduce-Side GROUP BY MERGEPARTIAL with duplicate columns is broken (Matt McCline, reviewed by Teddy Choi) + git merge --ff-only origin/master Already up-to-date. + date '+%Y-%m-%d %T.%3N' 2017-12-15 19:37:06.352 + rm -rf ../yetus + mkdir ../yetus + cp -R . ../yetus + mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-8273/yetus + patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh + patchFilePath=/data/hiveptest/working/scratch/build.patch + [[ -f /data/hiveptest/working/scratch/build.patch ]] + chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh + /data/hiveptest/working/scratch/smart-apply-patch.sh /data/hiveptest/working/scratch/build.patch error: patch failed: jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java:138 Falling back to three-way merge... Applied patch to 'jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java' with conflicts. error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java:38 Falling back to three-way merge... Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java' with conflicts. error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java:144 Falling back to three-way merge... Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java' with conflicts. error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java:17 Falling back to three-way merge... Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java' with conflicts. error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRelDecorrelator.java:1130 Falling back to three-way merge... Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRelDecorrelator.java' with conflicts. error: patch failed: ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java:87 Falling back to three-way merge... Applied patch to 'ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java' with conflicts. Going to apply patch with: git apply -p0 /data/hiveptest/working/scratch/build.patch:2103: trailing whitespace. } /data/hiveptest/working/scratch/build.patch:4228: trailing whitespace. <mkdir dir="${project.build.directory}/qfile-results/clientpositive/perf" /> /data/hiveptest/working/scratch/build.patch:8148: trailing whitespace. * /data/hiveptest/working/scratch/build.patch:15375: trailing whitespace. // FIXME: remove the Colneable usage /data/hiveptest/working/scratch/build.patch:19050: trailing whitespace. COLUMN_STATS_ACCURATE {} error: patch failed: jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java:138 Falling back to three-way merge... Applied patch to 'jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java' with conflicts. error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java:38 Falling back to three-way merge... Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java' with conflicts. error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java:144 Falling back to three-way merge... Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java' with conflicts. error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java:17 Falling back to three-way merge... Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java' with conflicts. error: patch failed: ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRelDecorrelator.java:1130 Falling back to three-way merge... Applied patch to 'ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRelDecorrelator.java' with conflicts. error: patch failed: ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java:87 Falling back to three-way merge... Applied patch to 'ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java' with conflicts. U jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java U ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java U ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java U ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java U ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveRelDecorrelator.java U ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java warning: squelched 584 whitespace errors warning: 589 lines add whitespace errors. + exit 1 ' {noformat} This message is automatically generated. ATTACHMENT ID: 12902200 - PreCommit-HIVE-Build > TopN: Create a standalone vectorizable TopN operator > ---------------------------------------------------- > > Key: HIVE-17896 > URL: https://issues.apache.org/jira/browse/HIVE-17896 > Project: Hive > Issue Type: New Feature > Components: Operators > Affects Versions: 3.0.0 > Reporter: Gopal V > Assignee: Teddy Choi > Attachments: HIVE-17896.1.patch, HIVE-17896.2.patch > > > For TPC-DS Query27, the TopN operation is delayed by the group-by - the > group-by operator buffers up all the rows before discarding the 99% of the > rows in the TopN Hash within the ReduceSink Operator. > The RS TopN operator is very restrictive as it only supports doing the > filtering on the shuffle keys, but it is better to do this before breaking > the vectors into rows and losing the isRepeating properties. > Adding a TopN operator in the physical operator tree allows the following to > happen. > GBY->RS(Top=1) > can become > TopN(1)->GBY->RS(Top=1) > So that, the TopN can remove rows before they are buffered into the GBY and > consume memory. > Here's the equivalent implementation in Presto > https://github.com/prestodb/presto/blob/master/presto-main/src/main/java/com/facebook/presto/operator/TopNOperator.java#L35 > Adding this as a sub-feature of GroupBy prevents further optimizations if the > GBY is on keys "a,b,c" and the TopN is on just "a". -- This message was sent by Atlassian JIRA (v6.4.14#64029)