[ 
https://issues.apache.org/jira/browse/HIVE-18294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16301868#comment-16301868
 ] 

Eugene Koifman commented on HIVE-18294:
---------------------------------------

I would prefer to only have the prop in MetastoreConf and the logic in 
TransactionalValidationListener - that would have been clean but there is some 
pushback on this.  See HIVE-18285.
Unfortunately, CTAS command writes the data first (this part needs to know if 
it's doing an Acid write) and then creates the metastore object which causes 
the Listener to run.  So I was forced to also put the same logic in 
SemanticAnalyzer.

I don't think the Conf object in SemanticAnalzyer has the MetastoreConf keys - 
but I would have run a test to make sure; it's a little hazy at this point.


> add switch to make acid table the default
> -----------------------------------------
>
>                 Key: HIVE-18294
>                 URL: https://issues.apache.org/jira/browse/HIVE-18294
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Transactions
>    Affects Versions: 3.0.0
>            Reporter: Eugene Koifman
>            Assignee: Eugene Koifman
>         Attachments: HIVE-18294.01.patch, HIVE-18294.03.patch, 
> HIVE-18294.04.patch
>
>
> it would be convenient for testing to have a switch that enables the behavior 
> where all suitable table tables (currently ORC + not sorted) are 
> automatically created with transactional=true, ie. full acid.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to