[
https://issues.apache.org/jira/browse/HIVE-16826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16308492#comment-16308492
]
Aihua Xu commented on HIVE-16826:
---------------------------------
[~belugabehr] Your change is much cleaner. I'm wondering if we have tests to
cover SeparatedValuesOutputFormat since by reading the code I'm not sure if
they behaves the same.
> Improvements for SeparatedValuesOutputFormat
> --------------------------------------------
>
> Key: HIVE-16826
> URL: https://issues.apache.org/jira/browse/HIVE-16826
> Project: Hive
> Issue Type: Bug
> Components: Beeline
> Affects Versions: 2.1.1, 3.0.0
> Reporter: BELUGA BEHR
> Assignee: BELUGA BEHR
> Priority: Minor
> Attachments: HIVE-16826.1.patch, HIVE-16826.2.patch
>
>
> Proposing changes to class
> {{org.apache.hive.beeline.SeparatedValuesOutputFormat}}.
> # Simplify the code
> # Code currently creates and destroys {{CsvListWriter}}, which contains a
> buffer, for every line printed
> # Use Apache Commons libraries for certain actions
> # Prefer non-synchronized {{StringBuilderWriter}} to Java's synchronized
> {{StringWriter}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
