Github user myui commented on a diff in the pull request:
https://github.com/apache/incubator-hivemall/pull/52#discussion_r103402140
--- Diff: core/src/main/java/hivemall/evaluation/AUCUDAF.java ---
@@ -49,35 +51,264 @@
@SuppressWarnings("deprecation")
@Description(
name = "auc",
- value = "_FUNC_(array rankItems, array correctItems [, const int
recommendSize = rankItems.size])"
+ value = "_FUNC_(array rankItems | double score, array correctItems
| int label "
+ + "[, const int recommendSize = rankItems.size ])"
+ " - Returns AUC")
public final class AUCUDAF extends AbstractGenericUDAFResolver {
- // prevent instantiation
- private AUCUDAF() {}
-
@Override
public GenericUDAFEvaluator getEvaluator(@Nonnull TypeInfo[] typeInfo)
throws SemanticException {
if (typeInfo.length != 2 && typeInfo.length != 3) {
throw new UDFArgumentTypeException(typeInfo.length - 1,
"_FUNC_ takes two or three arguments");
}
- ListTypeInfo arg1type = HiveUtils.asListTypeInfo(typeInfo[0]);
- if
(!HiveUtils.isPrimitiveTypeInfo(arg1type.getListElementTypeInfo())) {
- throw new UDFArgumentTypeException(0,
- "The first argument `array rankItems` is invalid form: " +
typeInfo[0]);
+ if (HiveUtils.isNumberTypeInfo(typeInfo[0]) &&
HiveUtils.isIntegerTypeInfo(typeInfo[1])) {
+ return new ClassificationEvaluator();
+ } else {
+ ListTypeInfo arg1type = HiveUtils.asListTypeInfo(typeInfo[0]);
+ if
(!HiveUtils.isPrimitiveTypeInfo(arg1type.getListElementTypeInfo())) {
+ throw new UDFArgumentTypeException(0,
+ "The first argument `array rankItems` is invalid form:
" + typeInfo[0]);
+ }
+
+ ListTypeInfo arg2type = HiveUtils.asListTypeInfo(typeInfo[1]);
+ if
(!HiveUtils.isPrimitiveTypeInfo(arg2type.getListElementTypeInfo())) {
+ throw new UDFArgumentTypeException(1,
+ "The second argument `array correctItems` is invalid
form: " + typeInfo[1]);
+ }
+
+ return new RankingEvaluator();
+ }
+ }
+
+ public static class ClassificationEvaluator extends
GenericUDAFEvaluator {
+
+ private PrimitiveObjectInspector scoreOI;
+ private PrimitiveObjectInspector labelOI;
+
+ private StructObjectInspector internalMergeOI;
+ private StructField aField;
+ private StructField scorePrevField;
+ private StructField fpField;
+ private StructField tpField;
+ private StructField fpPrevField;
+ private StructField tpPrevField;
+
+ public ClassificationEvaluator() {}
+
+ @Override
+ public ObjectInspector init(Mode mode, ObjectInspector[]
parameters) throws HiveException {
+ assert (parameters.length == 2 || parameters.length == 3) :
parameters.length;
+ super.init(mode, parameters);
+
+ // initialize input
+ if (mode == Mode.PARTIAL1 || mode == Mode.COMPLETE) {// from
original data
+ this.scoreOI =
HiveUtils.asDoubleCompatibleOI(parameters[0]);
+ this.labelOI = HiveUtils.asIntegerOI(parameters[1]);
+ } else {// from partial aggregation
+ StructObjectInspector soi = (StructObjectInspector)
parameters[0];
+ this.internalMergeOI = soi;
+ this.aField = soi.getStructFieldRef("a");
+ this.scorePrevField = soi.getStructFieldRef("scorePrev");
+ this.fpField = soi.getStructFieldRef("fp");
+ this.tpField = soi.getStructFieldRef("tp");
+ this.fpPrevField = soi.getStructFieldRef("fpPrev");
+ this.tpPrevField = soi.getStructFieldRef("tpPrev");
+ }
+
+ // initialize output
+ final ObjectInspector outputOI;
+ if (mode == Mode.PARTIAL1 || mode == Mode.PARTIAL2) {//
terminatePartial
+ outputOI = internalMergeOI();
+ } else {// terminate
+ outputOI =
PrimitiveObjectInspectorFactory.writableDoubleObjectInspector;
+ }
+ return outputOI;
+ }
+
+ private static StructObjectInspector internalMergeOI() {
+ ArrayList<String> fieldNames = new ArrayList<String>();
+ ArrayList<ObjectInspector> fieldOIs = new
ArrayList<ObjectInspector>();
+
+ fieldNames.add("a");
+
fieldOIs.add(PrimitiveObjectInspectorFactory.writableDoubleObjectInspector);
+ fieldNames.add("scorePrev");
+
fieldOIs.add(PrimitiveObjectInspectorFactory.writableDoubleObjectInspector);
+ fieldNames.add("fp");
+
fieldOIs.add(PrimitiveObjectInspectorFactory.writableLongObjectInspector);
+ fieldNames.add("tp");
+
fieldOIs.add(PrimitiveObjectInspectorFactory.writableLongObjectInspector);
+ fieldNames.add("fpPrev");
+
fieldOIs.add(PrimitiveObjectInspectorFactory.writableLongObjectInspector);
+ fieldNames.add("tpPrev");
+
fieldOIs.add(PrimitiveObjectInspectorFactory.writableLongObjectInspector);
+
+ return
ObjectInspectorFactory.getStandardStructObjectInspector(fieldNames, fieldOIs);
+ }
+
+ @Override
+ public AggregationBuffer getNewAggregationBuffer() throws
HiveException {
+ AggregationBuffer myAggr = new
ClassificationAUCAggregationBuffer();
+ reset(myAggr);
+ return myAggr;
+ }
+
+ @Override
+ public void reset(AggregationBuffer agg) throws HiveException {
+ ClassificationAUCAggregationBuffer myAggr =
(ClassificationAUCAggregationBuffer) agg;
+ myAggr.reset();
+ }
+
+ @Override
+ public void iterate(AggregationBuffer agg, Object[] parameters)
throws HiveException {
+ ClassificationAUCAggregationBuffer myAggr =
(ClassificationAUCAggregationBuffer) agg;
+
+ if (parameters[0] == null) {
+ return;
+ }
+ if (parameters[1] == null) {
+ return;
+ }
+
+ double score = HiveUtils.getDouble(parameters[0], scoreOI);
+
+ int label =
PrimitiveObjectInspectorUtils.getInt(parameters[1], labelOI);
+ if (label == -1) {
+ label = 0;
+ } else if (label != 0 && label != 1) {
+ throw new UDFArgumentException("label MUST be 0/1 or -1/1:
" + label);
+ }
+
+ myAggr.iterate(score, label);
}
- ListTypeInfo arg2type = HiveUtils.asListTypeInfo(typeInfo[1]);
- if
(!HiveUtils.isPrimitiveTypeInfo(arg2type.getListElementTypeInfo())) {
- throw new UDFArgumentTypeException(1,
- "The second argument `array correctItems` is invalid form:
" + typeInfo[1]);
+
+ @Override
+ public Object terminatePartial(AggregationBuffer agg) throws
HiveException {
+ ClassificationAUCAggregationBuffer myAggr =
(ClassificationAUCAggregationBuffer) agg;
+
+ Object[] partialResult = new Object[6];
+ partialResult[0] = new DoubleWritable(myAggr.a);
+ partialResult[1] = new DoubleWritable(myAggr.scorePrev);
+ partialResult[2] = new LongWritable(myAggr.fp);
+ partialResult[3] = new LongWritable(myAggr.tp);
+ partialResult[4] = new LongWritable(myAggr.fpPrev);
+ partialResult[5] = new LongWritable(myAggr.tpPrev);
+ return partialResult;
+ }
+
+ @Override
+ public void merge(AggregationBuffer agg, Object partial) throws
HiveException {
+ if (partial == null) {
+ return;
+ }
+
+ Object aObj = internalMergeOI.getStructFieldData(partial,
aField);
+ Object scorePrevObj =
internalMergeOI.getStructFieldData(partial, scorePrevField);
+ Object fpObj = internalMergeOI.getStructFieldData(partial,
fpField);
+ Object tpObj = internalMergeOI.getStructFieldData(partial,
tpField);
+ Object fpPrevObj = internalMergeOI.getStructFieldData(partial,
fpPrevField);
+ Object tpPrevObj = internalMergeOI.getStructFieldData(partial,
tpPrevField);
+ double a =
PrimitiveObjectInspectorFactory.writableDoubleObjectInspector.get(aObj);
+ double scorePrev =
PrimitiveObjectInspectorFactory.writableDoubleObjectInspector.get(scorePrevObj);
+ long fp =
PrimitiveObjectInspectorFactory.writableLongObjectInspector.get(fpObj);
+ long tp =
PrimitiveObjectInspectorFactory.writableLongObjectInspector.get(tpObj);
+ long fpPrev =
PrimitiveObjectInspectorFactory.writableLongObjectInspector.get(fpPrevObj);
+ long tpPrev =
PrimitiveObjectInspectorFactory.writableLongObjectInspector.get(tpPrevObj);
+
+ ClassificationAUCAggregationBuffer myAggr =
(ClassificationAUCAggregationBuffer) agg;
+ myAggr.merge(a, scorePrev, fp, tp, fpPrev, tpPrev);
}
- return new Evaluator();
+ @Override
+ public DoubleWritable terminate(AggregationBuffer agg) throws
HiveException {
+ ClassificationAUCAggregationBuffer myAggr =
(ClassificationAUCAggregationBuffer) agg;
+ double result = myAggr.get();
+ return new DoubleWritable(result);
+ }
+
+ }
+
+ public static class ClassificationAUCAggregationBuffer extends
AbstractAggregationBuffer {
+
+ double a, scorePrev;
+ long fp, tp, fpPrev, tpPrev;
+
+ public ClassificationAUCAggregationBuffer() {
+ super();
+ }
+
+ void reset() {
+ this.a = 0.d;
+ this.scorePrev = Double.POSITIVE_INFINITY;
+ this.fp = 0;
+ this.tp = 0;
+ this.fpPrev = 0;
+ this.tpPrev = 0;
+ }
+
+ void merge(double o_a, double o_scorePrev, long o_fp, long o_tp,
long o_fpPrev, long o_tpPrev) {
+ // compute the latest, not scaled AUC
+ a = a + trapezoidArea(fp, fpPrev, tp, tpPrev);
+ o_a = o_a + trapezoidArea(o_fp, o_fpPrev, o_tp, o_tpPrev);
+
+ // sum up the partial areas
+ a = a + o_a;
+ if (scorePrev >= o_scorePrev) { // self is left-side
+ // adjust combined area by adding missing rectangle
+ a = a + trapezoidArea(fp + o_fp, fp, tp, tp);
+
+ // combine TP/FP counts; left-side curve should be base
+ fp = fp + o_fp;
+ tp = tp + o_tp;
+ fpPrev = fp + o_fpPrev;
+ tpPrev = tp + o_tpPrev;
+ } else { // self is right-side
+ a = a + trapezoidArea(fp + o_fp, o_fp, o_tp, o_tp);
+
+ fp = o_fp + fp;
+ tp = o_tp + tp;
+ fpPrev = o_fp + fpPrev;
+ tpPrev = o_tp + tpPrev;
+ }
+
+ // set current appropriate `scorePrev`
+ scorePrev = Math.min(scorePrev, o_scorePrev);
+
+ // subtract so that get() works correctly
+ a = a - trapezoidArea(fp, fpPrev, tp, tpPrev);
+ }
+
+ double get() {
+ if (tp == 0 || fp == 0) {
+ return 0.d;
+ }
+ double res = a + trapezoidArea(fp, fpPrev, tp, tpPrev);
+ return res / (tp * fp); // scale
+ }
+
+ void iterate(@Nonnull double score, @Nonnull int label) {
--- End diff --
Remove `@Nonnull` for primitives (never become null)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
