GitHub user takuti opened a pull request:
https://github.com/apache/incubator-hivemall/pull/87
[HIVEMALL-108] Support `-iter` option in generic predictors
## What changes were proposed in this pull request?
Support `-iter` option in both **generic classifier** and **regression** by
buffering input samples, with an auxiliary `-tol` option.
Ref. #79
## What type of PR is it?
Improvement
## What is the Jira issue?
https://issues.apache.org/jira/browse/HIVEMALL-108
## How was this patch tested?
- Unit test
- Passed with the same test cases which were used for the previous
"manual" iteration using for-loops
- Manual test on EMR
- Same as what I did in #79
## How to use this feature?
Nothing has been changed except for the new options :)
---
### Notice
In order to check convergence, this PR adds `-tol` option; it is not `-eps`
as pLSA #71 and LDA #66 have, because `-eps` already exists in generic
predictors as an option for adagrad/adadelta. For the sake of unifying
interface, `train_lda` and `train_plsa` might need to support `-tol` as alias
of the existing `-eps` option.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/takuti/incubator-hivemall general-learner-iter
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hivemall/pull/87.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #87
----
commit 8fe56eee4856c0b3d791380ab81a47d89a4d6407
Author: Takuya Kitazawa <[email protected]>
Date: 2017-06-19T22:38:15Z
Update loss function descriptions
commit 9b009051a9b817688e74ab81317eff44aaf152d0
Author: Takuya Kitazawa <[email protected]>
Date: 2017-06-20T21:37:57Z
Support `-iter` and `-tol` option in generic predictors
commit b0011380db97081f35378c1ea5a973858d52940d
Author: Takuya Kitazawa <[email protected]>
Date: 2017-06-20T21:50:50Z
Reduce buffer size
commit b2f0460f3c210c9afbb9cdf2c1247ec34e8c5db2
Author: Takuya Kitazawa <[email protected]>
Date: 2017-06-20T22:08:39Z
Format
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
