Github user takuti commented on a diff in the pull request:

    https://github.com/apache/incubator-hivemall/pull/91#discussion_r125120746
  
    --- Diff: resources/ddl/define-additional.hive ---
    @@ -9,6 +9,9 @@
     drop temporary function if exists tokenize_ja;
     create temporary function tokenize_ja as 
'hivemall.nlp.tokenizer.KuromojiUDF';
     
    +drop temporary function if exists tokenize_cn;
    +create temporary function tokenize_cn as 
'hivemall.nlp.tokenizer.SmartcnUDF';
    --- End diff --
    
    Could you also update `resources/ddl/define-udfs.td.hql`?
    
    ```
    $ grep -r 'tokenize_ja' resources/ddl
    resources/ddl/define-additional.hive:drop temporary function if exists 
tokenize_ja;
    resources/ddl/define-additional.hive:create temporary function tokenize_ja 
as 'hivemall.nlp.tokenizer.KuromojiUDF';
    resources/ddl/define-udfs.td.hql:create temporary function tokenize_ja as 
'hivemall.nlp.tokenizer.KuromojiUDF';
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to