Github user myui commented on the issue:
https://github.com/apache/incubator-hivemall/pull/93
@helenahm Thank you for your contribution!
- Could you resolve the conflict? You can add `public void testUTF8()` and
rename existing `public void test2()` to `public void testASCII()`.
- Could you apply Hivemall code formatting? You can use `mvn
formatter:format` or [this style
file](https://github.com/apache/incubator-hivemall/blob/master/resources/eclipse-style.xml)
for Eclipse/IntelliJ.
BTW, `hivemall.smile` package is used for the fork of
[smile](https://github.com/haifengl/smile/). It's better to use another
package. I'm considering to move general classes such as
[hivemall.smile.data.Attribute](https://github.com/apache/incubator-hivemall/blob/master/core/src/main/java/hivemall/smile/data/Attribute.java)
to
[hivemall.common](https://github.com/apache/incubator-hivemall/tree/master/core/src/main/java/hivemall/common).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
