Github user myui commented on a diff in the pull request:

    https://github.com/apache/incubator-hivemall/pull/92#discussion_r125588453
  
    --- Diff: core/src/main/java/hivemall/ftvec/binning/NumericHistogram.java 
---
    @@ -30,11 +30,9 @@
     /**
      * **THIS CLASS IS IMPORTED FROM HIVE 2.1.0 FOR COMPATIBILITY**
      *
    - * A generic, re-usable histogram class that supports partial 
aggregations. The algorithm is a
    - * heuristic adapted from the following paper: Yael Ben-Haim and Elad 
Tom-Tov,
    - * "A streaming parallel decision tree algorithm", J. Machine Learning 
Research 11 (2010), pp.
    - * 849--872. Although there are no approximation guarantees, it appears to 
work well with adequate
    - * data and a large (e.g., 20-80) number of histogram bins.
    + * A generic, re-usable histogram class that supports partial 
aggregations. The algorithm is a heuristic adapted from the following paper: 
Yael
    + * Ben-Haim and Elad Tom-Tov, "A streaming parallel decision tree 
algorithm", J. Machine Learning Research 11 (2010), pp. 849--872. Although 
there are
    + * no approximation guarantees, it appears to work well with adequate data 
and a large (e.g., 20-80) number of histogram bins.
    --- End diff --
    
    same as here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to