rmannibucau opened a new pull request, #5689: URL: https://github.com/apache/hop/pull/5689
Hi, this PR intends to make using formula faster, there are several changes - not sure all are interesting for hop but I'm proposing them, at least it can maybe help somebody else: * (most important one) use HSS POI impementation instead of XSS to bypass xmlbeans, this has the limitation of the column number but is way faster * (important) do not recreate the row per evaluation, this invalidates the formula cell cache (parsing) which is slow * (medium) do not copy (and even worse synchronize) the variable substitution since it is done in a safe context (the param is thread safe) and read only * (less important) do not compare variable with equalsIgnoreCase since they are lower cased before (the java impl is faster) * (not important) parse only once for all lines all variables in the formula Mainly thanks the first 3 changes my test (in the pr) went from 1mn to 7s locally. ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [X] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [X] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [-] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [X] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [X] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
