mattcasters opened a new pull request, #7712: URL: https://github.com/apache/hop/pull/7712
## Summary - Evaluated #2430 (migrated from HOP-4031): internal pipeline/workflow filename and name variables are already set at **runtime** (`PipelineEngineFactory` / `WorkflowEngineFactory` / hop-run) and **design-time** (Hop GUI graph open paths). - Strengthened `integration-tests/parameters_and_variables` test **0007** to assert **expected values** (including `Internal.Pipeline.Filename.Directory`, which the old test omitted). - Added unit tests on `PipelineMeta` / `WorkflowMeta` `setInternalHopVariables` with and without a filename. No product code change was required; this locks in the current behavior with regression tests. ## Test plan - [x] `./mvnw -pl engine -Dtest=PipelineMetaTest#testSetInternalHopVariables*,WorkflowMetaTest#testSetInternalHopVariables* test` - [x] hop-run `main-0007-internal-variables.hwf` under project `parameters_and_variables` (dev env) — pipeline + workflow assertions passed - [ ] CI: `parameters_and_variables` integration suite Fixes #2430 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
