goanpeca opened a new pull request, #7728:
URL: https://github.com/apache/hop/pull/7728

   ## Summary
   
   Resolves #7727
   
   The S3 Connection metadata type already supports an `Endpoint URL` and a 
`Path-style access` option, and both are passed through to the AWS SDK as 
`endpointOverride` / `forcePathStyle`. The AWS S3 VFS page only covered Amazon 
credentials, part size and testing, so neither option was documented anywhere 
in the user manual.
   
   This adds a short `S3-compatible services` section to 
`docs/hop-user-manual/modules/ROOT/pages/vfs/aws-s3-vfs.adoc` covering the two 
options, the fact that path-style access is only applied when an endpoint URL 
is set (`S3CommonFileSystem#getS3Client`), and the fact that the connection 
name is registered as a VFS scheme of its own (`S3VfsPlugin#getProviders`).
   
   Docs only, no code changes.
   
   ## Test plan
   
   - [x] Rendered `docs/hop-user-manual/modules/ROOT/pages/vfs/aws-s3-vfs.adoc` 
with Asciidoctor at `--failure-level=WARN`, no warnings or errors
   - [ ] Review the wording of the new `S3-compatible services` section
   
   ------------------------
   
   - [x] If you have a group of commits related to the same change, please 
squash your commits into one and force push your branch using `git rebase -i` 
(single commit)
   - [ ] Mention the appropriate issue in your description (for example: 
`addresses #123`), if applicable (no existing issue; happy to file one if you 
prefer)
   - [x] I hereby declare this contribution to be licensed under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to