mattcasters opened a new pull request, #7733:
URL: https://github.com/apache/hop/pull/7733

   ## Summary
   
   - Add an **ECMAScript level** option to the JavaScript transform so users 
can select the Mozilla Rhino language version (DEFAULT, 1.5–1.8, ES6, 
ECMASCRIPT).
   - Default is **ES6** (matches current Rhino engine default), so existing 
pipelines without the setting keep current behavior; legacy levels remain 
available for older scripts.
   - Apply the level at runtime, pipeline check, and Test script; document the 
levels and a short history of JS 1.5–1.8 / ES6 in the user manual.
   
   Fixes #2618
   
   ## Test plan
   
   - [x] Unit tests for `ScriptValuesEcmaVersion` (code resolution, ES6 
`let`/`const`, legacy DEFAULT rejects `let`)
   - [x] XML serialization round-trip includes `languageVersion`
   - [x] Full `plugins/transforms/javascript` test suite (48 tests) passes
   - [ ] Open JavaScript transform dialog: verify ECMAScript level combo and 
labels
   - [ ] Run a script with `let`/`const` under ES6
   - [ ] Switch to DEFAULT/1.5 and confirm legacy scripts still work (and 
modern syntax fails as expected)
   - [ ] Open an old pipeline without `languageVersion` and confirm it still 
runs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to