mattcasters opened a new pull request, #7972: URL: https://github.com/apache/hop/pull/7972
## Summary The Multi Mapping transform landed on `main` in #7958 with a broken metadata-injection unit test. `MultiMappingMetaInjectionTest` injects the XML key `inherit_all_vars` and skips the XML names `variable` / `input`. `BeanInjectionInfo` only registers the injection keys from `MappingParameters` / `MappingVariableMapping`: - `INHERIT_ALL_VARIABLES` - `VARIABLE` - `VALUE` CI on any PR based on current `main` therefore fails in `hop-transform-mapping`: ``` Property 'inherit_all_vars' not found for injection to class ...MultiMappingMeta Some properties where not tested: [VALUE, VARIABLE, INHERIT_ALL_VARIABLES] ``` This is a one-file test fix. It unblocks #7967, #7969, and any other open PR that is otherwise green. Same change is already on #7970. I will cherry-pick it onto #7969. #7967 is on @hansva's fork so that branch needs this commit or a rebase once this merges. ## Test plan - [x] `./mvnw -pl plugins/transforms/mapping -Dtest=MultiMappingMetaInjectionTest test` — Tests run: 1, Failures: 0 Fixes the CI failure introduced by #7958. ------------------------ - [x] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
