budaykiran94 opened a new issue, #8024:
URL: https://github.com/apache/hop/issues/8024

   ### Apache Hop version?
   
   2.20.0-SNAPSHOT
   
   ### Java version?
   
   21.0.12" 2026-07-21 LTS
   
   ### Operating system
   
   Windows
   
   ### What happened?
   
   The check() method in SalesforceInsertMeta, SalesforceUpdateMeta, 
SalesforceUpsertMeta and SalesforceDeleteMeta reports TYPE_RESULT_ERROR when 
the transform has incoming hops, and TYPE_RESULT_OK when it has none.
   
   All four are registered under BaseTransform.Category.Output and consume rows 
via getRow() in processRow(), so they cannot function without input. The 
condition is inverted relative to the convention used by other output 
transforms — TableOutputMeta reports ExpectedInputOk when input is present and 
ExpectedInputError when it is absent.
   
   The message keys in use (CheckResult.NoInputExpected / CheckResult.NoInput) 
are the ones appropriate to an input transform, which suggests the block was 
copied from SalesforceInputMeta, where the check is correct. The error text 
shown to users reads "This transform is not expecting nor reading any input", 
which is not true of these transforms.
   
   The existing testCheck assertions in the four corresponding test classes 
call check() with a null input argument and assert no error, so they encode the 
same inverted expectation.
   
   ### Issue Priority
   
   Priority: 3
   
   ### Issue Component
   
   Component: Transforms


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to