leehaut commented on PR #8275:
URL: https://github.com/apache/hop/pull/8275#issuecomment-5571960459
@bamaer Thanks Bart — really appreciate the thorough review, and for
checking this out locally.
You're right that Const.splitString is the wrong foundation here. Silently
dropping rows on unbalanced enclosures is data loss, and the trailing-empty
mismatch with the non-enclosure path is confusing. I'll replace that call with
the scanner you suggested so that:
- unterminated enclosures are logged and the remainder is kept as one value
(no silent row loss)
- trailing empty values stay consistent with Pattern.split(..., -1)
- doubled enclosures unescape per RFC 4180
I'll also add tests for trailing empties, unterminated enclosure, and ${VAR}
substitution on the enclosure field.
Thanks again for the replacement code — that made the follow-up very
straightforward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
