leehaut opened a new pull request, #8309: URL: https://github.com/apache/hop/pull/8309
Fix https://github.com/apache/hop/issues/8308 ## Summary - Completes the unfinished Group By `ignore_aggregate` / `field_ignore` feature that was already present in metadata (`TODO: make work in GUI & worker`) but ignored at runtime and missing from the dialog. - Rows where the configured boolean field is `true` are excluded from aggregation, while still participating in group detection. With *Include all rows*, ignored rows remain in the output with the group aggregates. - Adds GUI controls, Lombok cleanup for Group By metadata classes, unit/integration tests, and user manual documentation. ## Changes - **Runtime:** `GroupBy` skips `calcAggregate()` for ignored rows; resolves the ignore field index during initialization. - **GUI:** `GroupByDialog` adds *Ignore rows for aggregation* and *Ignore field name*. - **Meta / i18n:** injection keys, `en_US` / `zh_CN` labels; Lombok `@Getter` / `@Setter` on `GroupByMeta`, `GroupingField`, and `Aggregation`. - **Tests:** - Unit: `GroupByTest`, `IgnoreAggregateTest`, `GroupByMetaTest` (moved to correct package), `AggregationTest`, `GroupingFieldTest` - Integration: `0006-groupby-ignore-aggregate` wired into `main-0006-groupby.hwf` - **Docs:** `groupby.adoc` options for ignore aggregate ## Behavior | Input (`skip=true` amount=100 ignored) | Expected | |---|---| | amounts `10, 20, 30, 100` | `sum=60`, `count=3` | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
