mattcasters commented on PR #8305:
URL: https://github.com/apache/hop/pull/8305#issuecomment-5616183868
Thanks for the review — addressed in 0ed000d716:
1. **Token refresh / retry.** The 30s margin now applies whether or not the
token is renewable. A missing lease (`getAuthLeaseDuration() <= 0`) is treated
as expiring after that same margin instead of being cached forever. Kubernetes
auth failures (401/403) invalidate the cached client and retry the lookup once;
TOKEN auth is left as a single attempt so a bad static token does not loop.
2. **Leftover credentials.** Hidden widgets are still read by
`getWidgetsContents`, so `VariableResolverEditor` now calls `persistContents`
on save. That strips `vaultToken` when the type is Kubernetes and
`kubernetesJwt` when it is TOKEN. A variable in `authenticationType` (e.g.
`${VAULT_AUTH_TYPE}`) keeps both sets of credentials, and the editor shows
every credential field in that case so values are not wiped.
3. **`toUpperCase(Locale.ROOT)`** in `parseAuthType()` and `readAuthType()`,
with a unit test that switches the default locale to `tr-TR`.
The CI Docker-daemon caveat is noted; `@Testcontainers(disabledWithoutDocker
= true)` is unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
