mattcasters opened a new pull request, #8313:
URL: https://github.com/apache/hop/pull/8313
After **File → Import from Kettle/PDI** into a folder (not the current
project), `${PROJECT_HOME}` was left pointing at the destination folder while
the project toolbar still showed the original project.
Folder import always created `"Hop Import Project"` and called
`Project.modifyVariables()` on Hop GUI's live variable space. That overwrote
`PROJECT_HOME`, `HOP_PROJECT_NAME`, and the related project folders without
going through `enableHopGuiProject()`.
This change:
- Registers the import project and writes `project-config.json` without
applying it to the caller's variables, so the session that started the import
keeps its `PROJECT_HOME`.
- Writes imported connections through a local metadata provider instead of
`ProjectsUtil.enableProject(..., hopGui)`, so a future `HopImportConnections`
caller cannot switch the GUI project.
- Fires `MetadataChanged` and `ProjectUpdated` after a successful import so
the metadata perspective (including the category tree) and explorer pick up
files written to disk, without activating the new project.
Fixes #2865
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [x] Run `mvn clean install apache-rat:check` to make sure basic checks
pass. A more thorough check will be performed on your pull request
automatically.
- [x] If you have a group of commits related to the same change, please
squash your commits into one and force push your branch using `git rebase -i`.
- [x] Mention the appropriate issue in your description (for example:
`addresses #123`), if applicable.
To make clear that you license your contribution under the [Apache License
Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licensed under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
