leehaut commented on PR #8322: URL: https://github.com/apache/hop/pull/8322#issuecomment-5650351471
@bamaer Thanks for the review and for verifying the fix locally. Addressed both points: 1. Removed the outdated `// don't worry about "undefined" arguments` comment. 2. `LoadScriptFromTab()` with no arguments now throws immediately (`requires at least 1 argument`), consistent with the other helpers in this class. Added a fourth Rhino test for that case. Agreed on the behaviour-change note for the release notes — pipelines that previously relied on a missing/empty tab name being silently ignored will now fail fast on upgrade, which is intentional. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
