abhiramaab commented on PR #8343:
URL: https://github.com/apache/hop/pull/8343#issuecomment-5650778257
Thanks for the thorough review and guidance @mattcasters! I've reworked the
implementation to follow the recommended approach:
1. **Reverted `NotificationHttp.java`**: Removed all JUL/Log4j2
mutations and unit test references from `NotificationHttp`. Background
notification polling no
longer alters any logging configuration.
2. **Central Application-Level Placement**: Configured wire logging once
during startup in `HopEnvironment.init()`.
3. **Preserve Explicit Configurations**: Checks whether
`org.apache.hc.client5.http.wire` has already been explicitly configured with a
level (`getExplicitLevel()
!= null`). If explicitly set (e.g. via `-D` flags or intentional debug
setup), it is left untouched; otherwise it defaults to `INFO`.
4. **Clean Unit Tests**: Added unit tests in
`HopEnvironmentSystemPropertyTest` verifying both the default `INFO`
suppression and preservation of intentional
`DEBUG` settings, with cleanup in `finally` blocks to prevent test
pollution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
